-
Notifications
You must be signed in to change notification settings - Fork 0
fix: corrige falso positivo P1 causado por substring matching no grep #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🏷️ [bumpr] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
🚀 [bumpr] Bumped! |
Impacto
Corrige bug que bloqueava PRs incorretamente com violacoes P1 em codigo legado nao modificado.
Causa raiz (2 bugs combinados):
grep -F "arquivo:22"dava match emarquivo:220,arquivo:224,arquivo:225+Solucao:
grep -F→grep -xF: Match exato de linha inteira (previne:22dar match em:220)+(codigo realmente adicionado)Problema:
Cenarios testados
Cenario 1: PR com P1 em codigo legado (linhas nao modificadas)
https://github.com/asaasdev/asaas/pull/56138
https://github.com/asaasdev/asaas/actions/runs/21439419412/job/61782060843?pr=56138
Cenario 2: PR com P1 em linha realmente modificada
https://github.com/asaasdev/asaas/pull/56169
https://github.com/asaasdev/asaas/actions/runs/21454044692/job/61790054958?pr=56169