Skip to content

fix: corrige falso positivo P1 causado por substring matching no grep #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felipeeffting merged 1 commit into from
Jan 29, 2026
Merged

fix: corrige falso positivo P1 causado por substring matching no grep #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions entrypoint.sh
View file
Open in desktop
Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

codenarc-docker/entrypoint.sh

Line 27 in 6c66108

$includes_arg >/dev/null 2>&1

Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

codenarc-docker/entrypoint.sh

Line 66 in 6c66108

${INPUT_REVIEWDOG_FLAGS} >/dev/null || true

Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

codenarc-docker/entrypoint.sh

Line 76 in 6c66108

${INPUT_REVIEWDOG_FLAGS} >/dev/null || true

Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

codenarc-docker/entrypoint.sh

Line 86 in 6c66108

${INPUT_REVIEWDOG_FLAGS} >/dev/null || true

Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

codenarc-docker/entrypoint.sh

Line 27 in 6c66108

$includes_arg >/dev/null 2>&1

Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

codenarc-docker/entrypoint.sh

Line 66 in 6c66108

${INPUT_REVIEWDOG_FLAGS} >/dev/null || true

Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

codenarc-docker/entrypoint.sh

Line 76 in 6c66108

${INPUT_REVIEWDOG_FLAGS} >/dev/null || true

Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

codenarc-docker/entrypoint.sh

Line 86 in 6c66108

${INPUT_REVIEWDOG_FLAGS} >/dev/null || true

Original file line number Diff line number Diff line change
Expand Up @@ -106,21 +106,25 @@ build_changed_lines_cache() {
[ ! -s "$ALL_DIFF" ] && return

awk '
BEGIN { file = ""; line_num = 0 }
/^diff --git/ {
file = $3
sub(/^a\//, "", file)
print file >> "'"$CHANGED_FILES_CACHE"'"
if (file != "") print file >> "'"$CHANGED_FILES_CACHE"'"
line_num = 0
}
/^@@/ {
match($0, /\+([0-9]+)(,([0-9]+))?/)
range = substr($0, RSTART, RLENGTH)
sub(/^\+/, "", range)
split(range, parts, ",")
start = parts[1]
count = parts[2]
if (count == "") count = 1
for (i = start; i < start + count; i++)
print file ":" i >> "'"$CHANGED_LINES_CACHE"'"
if (match($0, /\+([0-9]+)/)) {
line_num = substr($0, RSTART+1, RLENGTH-1)
line_num = int(line_num)
}
next
}
/^\+/ && !/^\+\+\+/ {
if (file != "" && line_num > 0) {
print file ":" line_num >> "'"$CHANGED_LINES_CACHE"'"
line_num++
}
}
' "$ALL_DIFF"
}
Expand All @@ -130,11 +134,11 @@ is_changed() {
line="$2"

if [ -z "$line" ]; then
[ -f "$CHANGED_FILES_CACHE" ] && grep -qF "$file" "$CHANGED_FILES_CACHE" && return 0
[ -f "$CHANGED_FILES_CACHE" ] && grep -qxF "$file" "$CHANGED_FILES_CACHE" && return 0
return 1
fi

[ -f "$CHANGED_LINES_CACHE" ] && grep -qF "${file}:${line}" "$CHANGED_LINES_CACHE" && return 0
[ -f "$CHANGED_LINES_CACHE" ] && grep -qxF "${file}:${line}" "$CHANGED_LINES_CACHE" && return 0
return 1
}

Expand Down Expand Up @@ -195,11 +199,7 @@ check_blocking_rules() {
[ -z "$file" ] && continue

if [ -z "$line" ]; then
if is_changed "$file" ""; then
echo "🚨 BLOQUEADO: Violação P1 a nível de arquivo encontrada no arquivo alterado: $file"
found_blocking=1
break
fi
continue
else
if is_changed "$file" "$line"; then
echo "🚨 BLOQUEADO: Violação P1 encontrada na linha alterada: $file:$line"
Expand Down
Loading