Allow 'includes = ["."]' in the root of the repo#625
Open
keith wants to merge 1 commit intobazelbuild:mainfrom
Open
Allow 'includes = ["."]' in the root of the repo#625keith wants to merge 1 commit intobazelbuild:mainfrom
keith wants to merge 1 commit intobazelbuild:mainfrom
Conversation
This isn't really something you want to do in a large project, but this is a very common requirement of open source libraries that are part of the BCR. Today they are buildable when pulled in through bzlmod, but not when you're testing changes to them directly. Bazel already adds an `-iquote .` to the root of the repo for all builds, so if something is in your dependency tree, you can include it relatively with the path from the root. If you want to guard against that you can use layering_check to make sure deps are explicitly defined. Fixes bazelbuild#453
keith
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't really something you want to do in a large project, but this
is a very common requirement of open source libraries that are part of
the BCR. Today they are buildable when pulled in through bzlmod, but not
when you're testing changes to them directly.
Bazel already adds an
-iquote .to the root of the repo for allbuilds, so if something is in your dependency tree, you can include it
relatively with the path from the root. If you want to guard against
that you can use layering_check to make sure deps are explicitly
defined.
Fixes #453