Skip to content

Allow 'includes = ["."]' in the root of the repo #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keith wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow 'includes = ["."]' in the root of the repo #625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cc/common/cc_helper.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,10 +818,6 @@ def _include_dirs(ctx, additional_make_variable_substitutions):
if not sibling_repository_layout and path_contains_up_level_references(includes_path):
fail("Path references a path above the execution root.", attr = "includes")

if includes_path == ".":
fail("'" + includes_attr + "' resolves to the workspace root, which would allow this rule and all of its " +
"transitive dependents to include any file in your workspace. Please include only" +
" what you need", attr = "includes")
result.append(includes_path)

# We don't need to perform the above checks against out_includes_path again since any errors
Expand Down