fix(printer): ignore broken pipe on output streams#443
Open
gcomneno wants to merge 1 commit intocanonical:mainfrom
Open
fix(printer): ignore broken pipe on output streams#443gcomneno wants to merge 1 commit intocanonical:mainfrom
gcomneno wants to merge 1 commit intocanonical:mainfrom
Conversation
gcomneno
force-pushed
the
contrib/issue-378-broken-pipe-head
branch
2 times, most recently
from
ca739aa to
33fa2ac
Compare
gcomneno
force-pushed
the
contrib/issue-378-broken-pipe-head
branch
from
33fa2ac to
b45881f
Compare
Contributor
Author
|
The functional fix looks healthy: all test jobs passed. The remaining failures appear to be external to this change:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore
BrokenPipeErrorwhen writing to output streams in the printer.This avoids crashes when output is piped to an early-closing consumer (for example
head -n1) and the downstream stream closes before craft-cli finishes writing orcleaning up the terminal/output state.
Testing
pytest -q tests/unit/test_printer.py -k "broken_pipe" -rspytest -q tests/unit/test_printer.py -rspytest -q tests/integration/test_messages_integration.py -k "third_party_output" -rspytest -q tests/unit/test_messages_stream_cm.py -rsruff check craft_cli/printer.py tests/unit/test_printer.py