Fix Digirig Lite tone PTT greyed out on Android#380
Open
chrissnell wants to merge 1 commit into
Open
Conversation
The Android "Digirig Lite (tone PTT)" method keys the radio via an audio tone and needs no serial/HID device, but needsDevice() only skipped the device-selection step for VOX (ptt_method 4), not tone PTT (ptt_method 5). Selecting it pushed the operator into the device picker, which lists no devices for a method with no deviceClass, leaving Save permanently disabled so the method could never be applied. Treat ptt_method 5 like VOX and like desktop's digirig_tone: skip the device step and persist directly.
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a fresh install, the new Digirig Lite tone PTT method can't be selected on Android — the operator gets stuck on a device-picker step with no devices and a permanently greyed-out Save button.
Cause
Digirig Lite tone PTT keys the radio with an audio tone and needs no serial/HID device (the same as VOX, and the same as desktop's
digirig_tone). ButneedsDevice()inPtt.svelteonly skipped the device-selection step for Android VOX (ptt_method 4), not tone PTT (ptt_method 5). Selecting it routed intoDialogChangeDevice, whose Android device source returns an empty list for any method with nodeviceClass— soSave(gated on a selected device) stayed disabled and the method could never be applied.The Android methods table already documents that tone PTT carries no
deviceClass; only theneedsDevicegate was out of sync.Fix
Treat Android
ptt_method 5like VOX: skip the device step and persist directly. One-line change mirroring the existing desktopdigirig_tonehandling.All 365 web unit tests pass.