build: relax pinned build dependencies in setup.py#271
build: relax pinned build dependencies in setup.py#271nemith wants to merge 1 commit intocloudsmith-io:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Relaxes strict runtime dependency pins in setup.py to reduce downstream packaging conflicts (e.g., Nix) when newer versions of mcp / python-toon are available.
Changes:
- Change
mcprequirement from==1.9.1to>=1.9.1. - Change
python-toonrequirement from==0.1.2to>=0.1.2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| "mcp==1.9.1", | ||
| "python-toon==0.1.2", | ||
| "mcp>=1.9.1", | ||
| "python-toon>=0.1.2", |
There was a problem hiding this comment.
Relaxing these dependencies to only a lower bound means future major releases (e.g., mcp 2.x / python-toon 1.x) could be selected and break the CLI at install time. Consider adding an upper bound (or using a compatible-release spec) based on the highest version known to work, and bump it intentionally when compatibility is verified.
| "python-toon>=0.1.2", | |
| "python-toon>=0.1.2,<1.0.0", |
| "mcp==1.9.1", | ||
| "python-toon==0.1.2", | ||
| "mcp>=1.9.1", | ||
| "python-toon>=0.1.2", |
There was a problem hiding this comment.
PR description mentions pinning/enforcing versions in requirements.in and regenerating requirements.txt, but this change set appears to only adjust setup.py; requirements.in currently still leaves python-toon unpinned. Either include the corresponding requirements.in/requirements.txt updates, or update the PR description to match what’s actually being changed.
Description
Two new dependences,
mcpandpythont-toonwere recently added with pinned versions. While trying to package cloudsmith-cli for nixos the version mismatches caused build conflicts.This relaxes the build contraints to allow for newer versions of both but enforces the pinning in requirements.in (
mcpwas already ther but also addedpythont-toon).Also regenerated requirements.txt which seemed to not have been generated automatincally in some time?
Type of Change
Additional Notes