Skip to content

build: relax pinned build dependencies in setup.py#271

Open
nemith wants to merge 1 commit intocloudsmith-io:masterfrom
nemith:bugfix-relaxdeps
Open

build: relax pinned build dependencies in setup.py#271
nemith wants to merge 1 commit intocloudsmith-io:masterfrom
nemith:bugfix-relaxdeps

Conversation

@nemith
Copy link

@nemith nemith commented Mar 9, 2026

Description

Two new dependences, mcp and pythont-toon were recently added with pinned versions. While trying to package cloudsmith-cli for nixos the version mismatches caused build conflicts.

This relaxes the build contraints to allow for newer versions of both but enforces the pinning in requirements.in (mcp was already ther but also added pythont-toon).

Also regenerated requirements.txt which seemed to not have been generated automatincally in some time?

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Other (Build update)

Additional Notes

Copilot AI review requested due to automatic review settings March 9, 2026 17:05
@nemith nemith requested a review from a team as a code owner March 9, 2026 17:05
@nemith nemith force-pushed the bugfix-relaxdeps branch from 6d4380d to 0d19cd0 Compare March 9, 2026 17:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Relaxes strict runtime dependency pins in setup.py to reduce downstream packaging conflicts (e.g., Nix) when newer versions of mcp / python-toon are available.

Changes:

  • Change mcp requirement from ==1.9.1 to >=1.9.1.
  • Change python-toon requirement from ==0.1.2 to >=0.1.2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

"mcp==1.9.1",
"python-toon==0.1.2",
"mcp>=1.9.1",
"python-toon>=0.1.2",
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relaxing these dependencies to only a lower bound means future major releases (e.g., mcp 2.x / python-toon 1.x) could be selected and break the CLI at install time. Consider adding an upper bound (or using a compatible-release spec) based on the highest version known to work, and bump it intentionally when compatibility is verified.

Suggested change
"python-toon>=0.1.2",
"python-toon>=0.1.2,<1.0.0",

Copilot uses AI. Check for mistakes.
"mcp==1.9.1",
"python-toon==0.1.2",
"mcp>=1.9.1",
"python-toon>=0.1.2",
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description mentions pinning/enforcing versions in requirements.in and regenerating requirements.txt, but this change set appears to only adjust setup.py; requirements.in currently still leaves python-toon unpinned. Either include the corresponding requirements.in/requirements.txt updates, or update the PR description to match what’s actually being changed.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants