Skip to content

build: relax pinned build dependencies in setup.py #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nemith wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −31
Open

build: relax pinned build dependencies in setup.py #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ pip-tools
pre-commit
pylint
pytest-cov
python-toon
python-toon==0.1.2
mcp==1.9.1
33 changes: 5 additions & 28 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.10
# This file is autogenerated by pip-compile with Python 3.14
# by the following command:
#
# pip-compile --output-file=requirements.txt requirements.in setup.py
Expand All @@ -14,8 +14,6 @@ anyio==4.12.1
# starlette
astroid==4.0.3
# via pylint
backports-tarfile==1.2.0
# via jaraco-context
build==1.4.0
# via pip-tools
bump2version==1.0.1
Expand Down Expand Up @@ -55,10 +53,6 @@ dill==0.4.1
# via pylint
distlib==0.4.0
# via virtualenv
exceptiongroup==1.3.1
# via
# anyio
# pytest
filelock==3.20.3
# via virtualenv
freezegun==1.5.5
Expand All @@ -82,8 +76,6 @@ idna==3.11
# anyio
# httpx
# requests
importlib-metadata==8.7.1
# via keyring
iniconfig==2.3.0
# via pytest
isort==7.0.0
Expand Down Expand Up @@ -155,6 +147,10 @@ python-dotenv==1.2.1
# via pydantic-settings
python-multipart==0.0.21
# via mcp
python-toon==0.1.2
# via
# -r requirements.in
# cloudsmith-cli (setup.py)
pyyaml==6.0.3
# via pre-commit
requests==2.32.5
Expand All @@ -176,30 +172,13 @@ starlette==0.52.1
# via
# mcp
# sse-starlette
tomli==2.4.0
# via
# build
# coverage
# pip-tools
# pylint
# pytest
tomlkit==0.14.0
# via pylint
python-toon==0.1.2
# via
# -r requirements.in
# cloudsmith-cli (setup.py)
typing-extensions==4.15.0
# via
# anyio
# astroid
# exceptiongroup
# pydantic
# pydantic-core
# starlette
# typing-inspection
# uvicorn
# virtualenv
typing-inspection==0.4.2
# via
# pydantic
Expand All @@ -215,8 +194,6 @@ virtualenv==20.36.1
# via pre-commit
wheel==0.46.3
# via pip-tools
zipp==3.23.0
# via importlib-metadata

# The following packages are considered to be unsafe in a requirements file:
# pip
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ def get_long_description():
"json5>=0.9.0", # For parsing JSONC (JSON with comments) in VS Code settings
"cloudsmith-api>=2.0.24,<3.0", # Compatible upto (but excluding) 3.0+
"keyring>=25.4.1",
"mcp==1.9.1",
"python-toon==0.1.2",
"mcp>=1.9.1",
"python-toon>=0.1.2",
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relaxing these dependencies to only a lower bound means future major releases (e.g., mcp 2.x / python-toon 1.x) could be selected and break the CLI at install time. Consider adding an upper bound (or using a compatible-release spec) based on the highest version known to work, and bump it intentionally when compatibility is verified.

Suggested change
"python-toon>=0.1.2",
"python-toon>=0.1.2,<1.0.0",

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description mentions pinning/enforcing versions in requirements.in and regenerating requirements.txt, but this change set appears to only adjust setup.py; requirements.in currently still leaves python-toon unpinned. Either include the corresponding requirements.in/requirements.txt updates, or update the PR description to match what’s actually being changed.

Copilot uses AI. Check for mistakes.
"requests>=2.18.4",
"requests_toolbelt>=1.0.0",
"semver>=2.7.9",
Expand Down