Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables runner persistence by disabling automatic deregistration when GitHub runners are reused. The change allows runners to remain registered with GitHub Actions between job executions, improving efficiency for environments with runner re-use.
- Adds
DISABLE_AUTOMATIC_DEREGISTRATION: 'true'environment variable to the runner container configuration - Bumps version from 0.1.0 to 0.1.2
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| roles/github_runner/tasks/main.yml | Adds DISABLE_AUTOMATIC_DEREGISTRATION environment variable to prevent runner deregistration when containers are reused |
| galaxy.yml | Updates collection version from 0.1.0 to 0.1.2 to reflect the persistence fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| license_file: LICENSE | ||
| readme: README.md | ||
| version: 0.1.1 | ||
| version: 0.1.2 |
There was a problem hiding this comment.
The version is being bumped from 0.1.0 to 0.1.2, skipping 0.1.1. Consider whether this skip is intentional or if the version should be 0.1.1 instead. If version 0.1.1 was previously released, this is correct; otherwise, following sequential versioning would be more conventional.
| version: 0.1.2 | |
| version: 0.1.1 |
| @@ -25,6 +25,7 @@ | |||
| { | |||
| 'ACCESS_TOKEN': github_runner_personal_access_token, | |||
| 'DISABLE_AUTO_UPDATE': 'true', | |||
There was a problem hiding this comment.
The new DISABLE_AUTOMATIC_DEREGISTRATION environment variable is not verified in the test suite. Consider adding a test assertion in the verify.yml files to ensure this environment variable is correctly set in the container configuration, similar to how other environment variables like REPO_URL and RUNNER_SCOPE are verified.
1 participant
disable runner dereg when we have runner re-use