Skip to content

fix persistence 2 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compscidr merged 3 commits into from
Jan 5, 2026
Merged

fix persistence 2 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae5b0dd
prevent deregistration when we have runner re-use
compscidr Jan 5, 2026
f5e9000
persistence fix: disable runner dereg when we reuse runner
compscidr Jan 5, 2026
ebaa9ce
merge origin/main
compscidr Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion galaxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ description: "Installs github self hosted repo or org runners within a docker co
can be a vanilla runner, or one with java / android installed."
license_file: LICENSE
readme: README.md
version: 0.1.1
version: 0.1.2
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is being bumped from 0.1.0 to 0.1.2, skipping 0.1.1. Consider whether this skip is intentional or if the version should be 0.1.1 instead. If version 0.1.1 was previously released, this is correct; otherwise, following sequential versioning would be more conventional.

Suggested change
version: 0.1.2
version: 0.1.1

Copilot uses AI. Check for mistakes.
repository: https://github.com/compscidr/ansible-github-runner
tags:
- github
Expand Down
1 change: 1 addition & 0 deletions roles/github_runner/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
{
'ACCESS_TOKEN': github_runner_personal_access_token,
'DISABLE_AUTO_UPDATE': 'true',
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new DISABLE_AUTOMATIC_DEREGISTRATION environment variable is not verified in the test suite. Consider adding a test assertion in the verify.yml files to ensure this environment variable is correctly set in the container configuration, similar to how other environment variables like REPO_URL and RUNNER_SCOPE are verified.

Copilot uses AI. Check for mistakes.
'DISABLE_AUTOMATIC_DEREGISTRATION': 'true',
'RUNNER_NAME_PREFIX': github_runner_name,
'LABELS': github_runner_labels,
'HOST_NAME': inventory_hostname,
Expand Down