Remove jaxtyping dependency #121
Conversation
Summary: Gets rid of the jaxtyping dependency as proposed in cornellius-gp#113 (due to limited value and causing dependency issues in some places). Test Plan: unit tests
These aren't necessary
|
|
cornellius-gp/linear_operator#121 removes jaxtyping from `linear_operator`, this removes the only occurrance also from gpytorch.
jacobrgardner
left a comment
jacobrgardner
left a comment
There was a problem hiding this comment.
This was a pretty big one of very "samey" changes but I scrolled through slowly and they all looked right to me.
| # Claude | ||
| CLAUDE.md | ||
|
|
There was a problem hiding this comment.
I am assuming this is the prompt for Claude? Let's remove it.
There was a problem hiding this comment.
I guess I'm adding it here so the prompt doesn't get included when people use claude, do you want me to remove it from .gitignore so we can consider committing a version of the prompt?
There was a problem hiding this comment.
Let me merge this for now; we can remove CLAUDE.md from .gitignore in a separate PR if we think that's the right move.
There was a problem hiding this comment.
I don't think we should commit the prompt.
I initially thought these lines were added by mistake (since they seemed to be unrelated to this PR), and so I wanted to flagged these lines. But it looks like this gitignore entry was added intentionally. So we are all set here!
|
Looks good to me as well. |
3 participants
Gets rid of the jaxtyping dependency as proposed in #113 (due to limited value and causing dependency issues in some places).