Skip to content

chore: fix symbol visibility #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashtum merged 1 commit into from
Dec 24, 2025
Merged

chore: fix symbol visibility #234

ashtum merged 1 commit into from
Dec 24, 2025

Conversation

@ashtum
Copy link
Collaborator

@ashtum ashtum commented Dec 24, 2025

No description provided.

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 24, 2025

An automated preview of the documentation is available at https://234.http-proto.prtest.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-12-24 12:43:31 UTC

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 24, 2025

GCOVR code coverage report https://234.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://234.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://234.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

Build time: 2025-12-24 12:50:02 UTC

ashtum
ashtum commented Dec 24, 2025
View reviewed changes
include/boost/http_proto/server/route_handler.hpp
class BOOST_HTTP_PROTO_SYMBOL_VISIBLE model
: public task
, public suspender::owner
class model: public task, suspender::owner
Copy link
Collaborator Author

@ashtum ashtum Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinniefalco, immediate and model are nested types inside a templated function. We shouldn't export their vtables, because there's no way they can be exported from the compiled shared library.

Copy link
Member

@vinniefalco vinniefalco Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to edit...

@ashtum ashtum merged commit 59f6d1b into cppalliance:develop Dec 24, 2025
61 of 62 checks passed
@ashtum ashtum deleted the fix-symbol-visibility branch December 24, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinniefalco vinniefalco vinniefalco left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashtum @cppalliance-bot @vinniefalco