Skip to content

chore: fix symbol visibility #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashtum merged 1 commit into from
Dec 24, 2025
Merged

chore: fix symbol visibility #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions include/boost/http_proto/server/route_handler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,7 @@ post(F&& f) -> route_result
if(task_)
detail::throw_invalid_argument();

struct BOOST_HTTP_PROTO_SYMBOL_VISIBLE
immediate : suspender::owner
struct immediate : suspender::owner
{
route_result rv;
bool set = false;
Expand All @@ -227,9 +226,7 @@ post(F&& f) -> route_result
}
};

class BOOST_HTTP_PROTO_SYMBOL_VISIBLE model
: public task
, public suspender::owner
class model: public task, suspender::owner
Copy link
Collaborator Author

@ashtum ashtum Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinniefalco, immediate and model are nested types inside a templated function. We shouldn't export their vtables, because there's no way they can be exported from the compiled shared library.

Copy link
Member

@vinniefalco vinniefalco Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to edit...

{
public:
model(route_params& p,
Expand Down
Loading