Skip to content

Traditional Chinese language update#305

Merged
darrylmorley merged 3 commits into
darrylmorley:mainfrom
jimmyorz:main
Jun 9, 2026
Merged

Traditional Chinese language update#305
darrylmorley merged 3 commits into
darrylmorley:mainfrom
jimmyorz:main

Conversation

@jimmyorz

@jimmyorz jimmyorz commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Improve translation consistency and refine updated strings.

Summary by CodeRabbit

  • Documentation
    • Updated Traditional Chinese (zh-Hant) copy across the app: clarified app-update/install messaging, made onboarding/welcome text more formal and consistent, refined status and diagnostics wording (including per-port live metering availability), and improved technical description phrasing for better clarity to Traditional Chinese-speaking users.

Improve translation consistency and refine updated strings.
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates several Traditional Chinese zh-Hant localized strings: formalizes onboarding copy, refines an app-update location message (安裝於此位置), adjusts “Raw IOKit registry properties…” wording, and tweaks diagnostics/per-port metering phrasing.

Changes

Traditional Chinese localization update

Layer / File(s) Summary
App onboarding & app-update message translations
Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.strings
Replaces informal pronouns with formal 您的/您 in onboarding strings, changes the app-update location phrasing to 安裝於此位置, and swaps “功能資訊” → “規格資訊” in the Raw IOKit properties string.
Core diagnostics translations
Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings
Refines per-port metering availability wording and updates several Display Diagnostics strings (e.g., “承載能力” → “承載”, “功率讀取” → “功率測量”, and phrasing about what the link is “carrying”).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

我是兔子在鍵盤旁,跳字與翻譯忙,
細修詞句換禮貌,安裝位置說得亮,
診斷文字更精準,讀者微笑不用慌,
小改動,大清晰,翻譯花開又一場。 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Traditional Chinese language update' accurately summarizes the main change in the PR: updates to Traditional Chinese localization strings across two files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jimmyorz

jimmyorz commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

@darrylmorley I think this string "in the location"may need a manual review.

In this context, "location" appears to refer to the application's installation location/path rather than a physical location. The current Traditional Chinese translation reads more like a real-world place.

Other machine-assisted translations may have the same issue. For example, the Japanese translation currently uses 「この場所」, which also reads as a physical location to me (I know a little Japanese 🙂).

Would something closer to "installation location" or "installation path" better match the intended meaning?

@jimmyorz jimmyorz marked this pull request as draft June 7, 2026 21:53
jimmyorz added 2 commits June 8, 2026 05:56
Improve translation consistency and refine technical terminology.
Improve translation consistency and refine technical terminology.
@jimmyorz jimmyorz marked this pull request as ready for review June 7, 2026 22:02

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.strings (1)

31-31: ⚡ Quick win

Verify the translation fully addresses the "installation location" concern.

The PR comment flags that "此位置" can read like a physical place rather than an installation path. While "安裝於此位置" adds clarification by including "安裝於" (installed at), it still retains "此位置" (this location), which may carry the same ambiguity.

Consider whether a more explicit term like "安裝路徑" (installation path) or "安裝目錄" (installation directory) would better convey that this refers to the app's file-system location rather than a physical place:

"此帳戶無法更新位於此安裝路徑的應用程式。請從 whatcable.uk 下載新版本,或使用 Homebrew 更新。"

or

"此帳戶無法更新此安裝目錄中的應用程式。請從 whatcable.uk 下載新版本,或使用 Homebrew 更新。"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.strings` at line 31,
The translated string for "This account can't update apps in this location.
Download the new version from whatcable.uk, or update with Homebrew." should
avoid the ambiguous "此位置"; update the Localizable.strings entry that maps that
English source text and replace "安裝於此位置" with a clearer term such as "位於此安裝路徑"
or, preferably, "此安裝目錄中" so it reads e.g. "此帳戶無法更新此安裝目錄中的應用程式。請從 whatcable.uk
下載新版本,或使用 Homebrew 更新。"; modify the translation string accordingly in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.strings`:
- Line 31: The translated string for "This account can't update apps in this
location. Download the new version from whatcable.uk, or update with Homebrew."
should avoid the ambiguous "此位置"; update the Localizable.strings entry that maps
that English source text and replace "安裝於此位置" with a clearer term such as
"位於此安裝路徑" or, preferably, "此安裝目錄中" so it reads e.g. "此帳戶無法更新此安裝目錄中的應用程式。請從
whatcable.uk 下載新版本,或使用 Homebrew 更新。"; modify the translation string accordingly
in the file.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f047658a-03f5-4a79-9903-7a251b2f33cf

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa9b5a and d35d125.

📒 Files selected for processing (2)
  • Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.strings
  • Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings
✅ Files skipped from review due to trivial changes (1)
  • Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings

@darrylmorley darrylmorley merged commit 3eb9201 into darrylmorley:main Jun 9, 2026
1 check passed
@darrylmorley

Copy link
Copy Markdown
Owner

Thank you @jimmyorz, sorry it took a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants