Traditional Chinese language update#305
Conversation
Improve translation consistency and refine updated strings.
📝 WalkthroughWalkthroughUpdates several Traditional Chinese ChangesTraditional Chinese localization update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@darrylmorley I think this string "in the location"may need a manual review. In this context, "location" appears to refer to the application's installation location/path rather than a physical location. The current Traditional Chinese translation reads more like a real-world place. Other machine-assisted translations may have the same issue. For example, the Japanese translation currently uses 「この場所」, which also reads as a physical location to me (I know a little Japanese 🙂). Would something closer to "installation location" or "installation path" better match the intended meaning? |
Improve translation consistency and refine technical terminology.
Improve translation consistency and refine technical terminology.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.strings (1)
31-31: ⚡ Quick winVerify the translation fully addresses the "installation location" concern.
The PR comment flags that "此位置" can read like a physical place rather than an installation path. While "安裝於此位置" adds clarification by including "安裝於" (installed at), it still retains "此位置" (this location), which may carry the same ambiguity.
Consider whether a more explicit term like "安裝路徑" (installation path) or "安裝目錄" (installation directory) would better convey that this refers to the app's file-system location rather than a physical place:
"此帳戶無法更新位於此安裝路徑的應用程式。請從 whatcable.uk 下載新版本,或使用 Homebrew 更新。"or
"此帳戶無法更新此安裝目錄中的應用程式。請從 whatcable.uk 下載新版本,或使用 Homebrew 更新。"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.strings` at line 31, The translated string for "This account can't update apps in this location. Download the new version from whatcable.uk, or update with Homebrew." should avoid the ambiguous "此位置"; update the Localizable.strings entry that maps that English source text and replace "安裝於此位置" with a clearer term such as "位於此安裝路徑" or, preferably, "此安裝目錄中" so it reads e.g. "此帳戶無法更新此安裝目錄中的應用程式。請從 whatcable.uk 下載新版本,或使用 Homebrew 更新。"; modify the translation string accordingly in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.strings`:
- Line 31: The translated string for "This account can't update apps in this
location. Download the new version from whatcable.uk, or update with Homebrew."
should avoid the ambiguous "此位置"; update the Localizable.strings entry that maps
that English source text and replace "安裝於此位置" with a clearer term such as
"位於此安裝路徑" or, preferably, "此安裝目錄中" so it reads e.g. "此帳戶無法更新此安裝目錄中的應用程式。請從
whatcable.uk 下載新版本,或使用 Homebrew 更新。"; modify the translation string accordingly
in the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f047658a-03f5-4a79-9903-7a251b2f33cf
📒 Files selected for processing (2)
Sources/WhatCable/Resources/zh-Hant.lproj/Localizable.stringsSources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings
✅ Files skipped from review due to trivial changes (1)
- Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings
|
Thank you @jimmyorz, sorry it took a while. |
Improve translation consistency and refine updated strings.
Summary by CodeRabbit