Settings: stop the content column shifting off-screen; keep segmented pickers#9
Closed
digitalerdude wants to merge 9 commits into
Closed
Settings: stop the content column shifting off-screen; keep segmented pickers#9digitalerdude wants to merge 9 commits into
digitalerdude wants to merge 9 commits into
Conversation
Two stdlib tools in Tools/linux-capture that turn a WHOOP data export into leverage for the un-decoded deep-record layouts tracked in ryanbr#103: - hci_extract.py: parse a phone Bluetooth HCI capture (iOS .pklg / Android btsnoop) of the official app, reassemble L2CAP/ATT, and emit the CRC-valid WHOOP frames as the project's capture.json. Only WHOOP streams reach the output. - correlate_ground_truth.py: known-plaintext field search. Cross-reference capture records against the official per-night values in a WHOOP CSV export (reusing the Swift importer's localized header aliases) to locate each biometric's byte offset + encoding. Distribution-overlap scoring (recall + precision) rejects constants and coincidences. Prints offsets only, so the output is safe to post on ryanbr#103 while health data stays local. Docs: new README sections + a ground-truth-correlation note in WHOOP5_DEEP_DATA.md. 25 new stdlib tests; full suite 129 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ReadinessChecklistCard.lead expects LocalizedStringKey?, but fitnessReadyLead() returns an already-resolved String. The mismatch broke the NOOPiOS build; wrap it explicitly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… pickers The six segmented pickers in the Units and Appearance cards used .fixedSize(), pinning them to their ideal width. Inside FormRow's label+control HStack that pushed the column past the screen width, so ScreenScaffold's centering shifted the whole Settings column ~37pt left — clipping the header's first letter and the cards' left/right margins (the overflow the ryanbr#43 note in this file already warns about). Remove the .fixedSize() calls so the pickers size to the row. To keep the two three-option pickers from truncating once they size down, shorten their long first labels to "Auto": Temperature's "Match" and the theme's "System" (AppearanceMode.system, shared with the onboarding pill). Add "Auto" translations to both string catalogs. Also fixes the profile-photo blurb: interpolating the nested-localized Platform.deviceNounPhrase broke its wrapping and read "diese iPhone" in German; use Platform.deviceNoun with "this" in the sentence so it wraps and reads "diesem iPhone". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # Strand/Screens/HealthView.swift
This was referenced Jul 9, 2026
…e-checker
The single-line nested-optional-coalescing form (gx ?? 0) * (gx ?? 0) + ...
occasionally blew the Swift type-checker's time budget in CI ("unable to
type-check this expression in reasonable time"), failing the WhoopProtocol
test job on unrelated PRs. A compiler perf cliff, not a real ambiguity;
naming the intermediate values fixes it without changing behavior.
2 tasks
…screen (ryanbr#161) The Units/Appearance segmented pickers used .segmented + .fixedSize(), which pins them to their ideal width and OVERFLOWS the Settings column once the labels are long or Text Size is enlarged -- SwiftUI then sizes the whole column to that overflowing row, so the Settings screen renders oversized/shifted (the ryanbr#161 report on iOS 26.5). This is the exact failure mode already documented + fixed for the Age/Sex pickers under ryanbr#43, which switched to .pickerStyle(.menu) (a compact button that fits any label length). Apply the same proven fix to the remaining eight: Measurement, Temperature, Effort scale, Theme, Chart colours, Trend charts, App icon, and the HRV window. The HRV window picker (added in 8.5.1, moved in 8.5.2) followed the old .fixedSize() pattern with unusually wide options ("Whole night"/"Deep sleep"), so it likely worsened this in 8.5.2 -- now fixed too. NB: removing .fixedSize() alone (the obvious fix) makes a segmented picker COLLAPSE per the ryanbr#43 note; .menu is the correct remedy. iOS-only (Android uses SegmentedPillControl, unaffected). Layout change -- verify on device.
…w-menu Settings: use .menu pickers so segmented controls can't oversize the screen (ryanbr#161)
# Conflicts: # Strand/Screens/SettingsView.swift
Owner
Author
|
Closing this fork-internal PR to declutter — the real submission lives at ryanbr/noop (upstream). See that repo's PR list for the current, actionable version of this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pickers in the Units/Appearance cards used.fixedSize(), pinning them to their ideal width. InsideFormRow's label(∞)+controlHStack, that pushed the column past the screen width (~476pt vs 402pt), andScreenScaffold's centering shifted everything left — the exact overflow the#43note inSettingsView.swiftalready warned about, just not caught for these six..fixedSize()calls so the pickers size to the row. To keep the two three-option pickers from truncating once they size down, shortened their long first labels to "Auto" (Temperature's "Match" and the theme's "System," the latter shared with the onboarding pill) and added translations for the new short labels.Platform.deviceNounPhrasebroke wrapping — switched toPlatform.deviceNounwith "this"/"diesem" written directly in the sentence.upstream/mainto resolve the resulting conflicts. That merge brought in the same.fixedSize()overflow bug in two more places (the HRV settings in one place (deep sleep window now is in units) ryanbr/noop#155 HRV-window grouping and the new Trend-charts picker) — removed there too, and shortened "Whole night" → "Night" (German "Über Nacht" still truncated at 10 chars; single-word "Nacht" fits reliably). Also added missing translations for "HRV window" (→ "HRV-Fenster") and its option labels, which had none before.Test plan
Strand) and iOS (NOOPiOS) targets both build clean viaxcodebuild.PickerinSettingsView.swiftstill carries.fixedSize()(grepped everypickerStyle(.segmented)call site).StrandDesignstring catalogs.🤖 Generated with Claude Code