chore: drop prepare script (build/ is committed for git installs)#8
Merged
Conversation
Now that build/ ships in the repo (#7), the prepare lifecycle is unneeded. Worse, leaving it in triggers an npm 11 bug for git-URL consumers: npm spawns the prepare child install with both --prefer-offline=false AND --prefer-online=false, which the cli now rejects as mutually exclusive. Removing prepare bypasses that path entirely and lets git-ref installs succeed on every npm version. prepublishOnly is kept so an eventual `npm publish` still runs the build before packaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7. With build/ committed, the prepare lifecycle is unneeded; leaving it in triggers an npm 11 bug for git-URL consumers (mutually exclusive --prefer-offline / --prefer-online flags during the spawned prepare install). Removing prepare bypasses that path; prepublishOnly is kept so a future npm publish still runs the build.