fix(skills): default SkillTagManager buttons to type="button"#68
Merged
Conversation
The remove-chip, add-toggle, and option-list buttons sit inside Admin/Skills/Form.vue's <form>. Without an explicit type they default to type="submit", so clicking any of them would submit the skill form before the user finished editing routing tags or departments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillTagManager.vue's three<button>elements (remove chip, add-toggle, dropdown option) had notypeattribute. InsideAdmin/Skills/Form.vue's<form>they default totype="submit", so any tag/department interaction would submit the skill form prematurely.type="button"to all three so they stay click-only.Test plan