Skip to content

fix(skills): default SkillTagManager buttons to type="button" #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpge merged 1 commit into from
May 13, 2026
+3 −0
Merged

fix(skills): default SkillTagManager buttons to type="button" #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/SkillTagManager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ function removeItem(value) {
>
{{ item[itemLabelKey] }}
<button
type="button"
:aria-label="`Remove ${item[itemLabelKey]}`"
class="ml-0.5 text-cyan-400 hover:text-cyan-200"
@click="removeItem(item[itemValueKey])"
Expand All @@ -60,6 +61,7 @@ function removeItem(value) {
<div class="relative">
<button
v-if="unselectedItems.length"
type="button"
class="rounded-lg border border-dashed border-white/[0.08] px-2 py-1 text-xs text-neutral-400 transition-colors hover:border-white/[0.15] hover:text-neutral-300"
@click="showDropdown = !showDropdown"
>
Expand All @@ -72,6 +74,7 @@ function removeItem(value) {
<button
v-for="item in unselectedItems"
:key="item[itemValueKey]"
type="button"
class="w-full px-3 py-1.5 text-left text-xs text-neutral-300 transition-colors hover:bg-white/[0.04]"
@click="addItem(item[itemValueKey])"
>
Expand Down