Skip to content

[ONB-1914] feat: expose userAgent option in Fintoc constructor#89

Merged
FranciscaOtero merged 1 commit intomasterfrom
onb-1914-expose-useragent-in-fintoc-constructor
Apr 30, 2026
Merged

[ONB-1914] feat: expose userAgent option in Fintoc constructor#89
FranciscaOtero merged 1 commit intomasterfrom
onb-1914-expose-useragent-in-fintoc-constructor

Conversation

@FranciscaOtero
Copy link
Copy Markdown
Contributor

@FranciscaOtero FranciscaOtero commented Apr 29, 2026

Contexto

El CLI necesita identificarse como fintoc-cli/<version> en los requests, pero Fintoc hardcodea el User-Agent a fintoc-node/<version>.

Que hay de nuevo?

  • Nuevo parámetro opcional options?: { userAgent?: string } en el constructor de Fintoc
  • Default sigue siendo fintoc-node/{version} (no breaking change)

Tests

  • Constructor acepta el nuevo parámetro
  • User-Agent custom llega en los headers de los requests
  • Sin custom User-Agent usa el default

@FranciscaOtero FranciscaOtero force-pushed the onb-1914-expose-useragent-in-fintoc-constructor branch from a24b3f5 to 1a53c4b Compare April 29, 2026 22:15
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@FranciscaOtero FranciscaOtero force-pushed the onb-1914-expose-useragent-in-fintoc-constructor branch from 1a53c4b to 74b6756 Compare April 29, 2026 22:20
@FranciscaOtero FranciscaOtero self-assigned this Apr 30, 2026
@FranciscaOtero FranciscaOtero changed the title feat: expose userAgent option in Fintoc constructor [ONB-1914] feat: expose userAgent option in Fintoc constructor Apr 30, 2026
Copy link
Copy Markdown

@vacodoceo vacodoceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FranciscaOtero FranciscaOtero merged commit ba6f072 into master Apr 30, 2026
2 checks passed
@tlarrain tlarrain deleted the onb-1914-expose-useragent-in-fintoc-constructor branch April 30, 2026 19:59
@oerlandsen oerlandsen mentioned this pull request Apr 30, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants