[ONB-1832] Fix string serialization being incorrectly parsed as Date#90
Merged
FranciscaOtero merged 1 commit intomasterfrom Apr 30, 2026
Merged
Conversation
…being parsed as dates Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
FranciscaOtero
force-pushed
the
onb-1832-fix-date-serialization-for-plain-strings
branch
from
ca3515d to
c4d4e67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
isISODate()usabaDate.parse()para validar si un string es una fecha ISO. El problema es queDate.parse()es extremadamente permisivo y parsea strings como"PS 2"o"test 1"como fechas válidas, causando que nombres de organizaciones y otros textos planos se conviertan en objetosDateal construir recursos.Se reemplazó
Date.parse()por un regex estricto de ISO 8601 que solo matchea formatos como2021-08-13o2021-08-13T13:40:40.811Z.Requirements
None.
Additional changes
isISODateygetResourceClasscubriendo los casos problemáticosCreated with Claude Code
/create-prcommand