Add accessibility functionality to onscreen slides #1
Closed
KelseyCooper wants to merge 2 commits intomasterfrom
Closed
Add accessibility functionality to onscreen slides #1KelseyCooper wants to merge 2 commits intomasterfrom
KelseyCooper wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR copies all functionality given here:
metafizzy#1032
Flickity automatically sets all slides to
aria-hidden="true"except the one currently selected.This is bad for accessibility. Anything that is
aria-hiddenshould not have focusable elements. This creates sliders that can only show one slide at a time to screen readers, or that will not show the furthest most slides at all ifcontain: true.Usage
This PR will be kept open. If any changes are released to flickity we pull into our fork then rebase this branch.
To update to use this PR change package.json:
"flickity": "^2.2.2"
to
"flickity": "https://github.com/fluorescent/flickity#af2adbb"