feat(pypi): support TWINE_VERBOSE env var to pass --verbose to twine upload#829
Merged
Conversation
…upload Co-authored-by: UJ38MKDFB <fpacifici@sentry.io>
joshuarli
approved these changes
Jun 4, 2026
This was referenced Jun 4, 2026
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When
TWINE_VERBOSE=true(or any truthy string) is set in the environment, craft will now pass--verboseto thetwine uploadinvocation. Without the env var the behavior is unchanged.Why
Twine's
--verboseflag exposes the full HTTP response body on errors, making 400 Bad Request failures diagnosable without patching craft's source. Today the only output on a 400 is a terseHTTPErrormessage with no detail about why PyPI rejected the upload (e.g. metadata validation errors, duplicate filenames, unsupported wheel tags). SettingTWINE_VERBOSE=truein the publish workflow lets operators get that detail without a code change.Context: getsentry/publish sentry-streams publish failure diagnosed in #discuss-dev-infra.
Verification
src/targets/__tests__/pypi.test.ts:uploadAssets omits --verbose when TWINE_VERBOSE is not setuploadAssets includes --verbose when TWINE_VERBOSE is setpnpm exec vitest run src/targets/__tests__/pypi.test.ts)Action taken on behalf of Filippo Pacifici.
View Session in Sentry