Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/targets/__tests__/pypi.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,34 @@ describe('pypi', () => {
'/path/to/pkg.tar.gz',
]);
});

test('uploadAssets omits --verbose when TWINE_VERBOSE is not set', async () => {
delete process.env.TWINE_VERBOSE;
vi.mocked(spawnProcess).mockResolvedValueOnce(Buffer.from(''));

const target = new PypiTarget({ name: 'pypi' }, new NoneArtifactProvider());
await target.uploadAssets(['/path/to/pkg.whl']);

expect(spawnProcess).toHaveBeenCalledWith('twine', [
'upload',
'/path/to/pkg.whl',
]);
});

test('uploadAssets includes --verbose when TWINE_VERBOSE is set', async () => {
process.env.TWINE_VERBOSE = 'true';
vi.mocked(spawnProcess).mockResolvedValueOnce(Buffer.from(''));

const target = new PypiTarget({ name: 'pypi' }, new NoneArtifactProvider());
await target.uploadAssets(['/path/to/pkg.whl', '/path/to/pkg.tar.gz']);

expect(spawnProcess).toHaveBeenCalledWith('twine', [
'upload',
'--verbose',
'/path/to/pkg.whl',
'/path/to/pkg.tar.gz',
]);

delete process.env.TWINE_VERBOSE;
});
});
7 changes: 6 additions & 1 deletion src/targets/pypi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,12 @@ export class PypiTarget extends BaseTarget {

async uploadAssets(paths: string[]): Promise<any> {
// TODO: Sign the package with "--sign"
return spawnProcess(TWINE_BIN, ['upload', ...paths]);
const args = ['upload'];
if (process.env.TWINE_VERBOSE) {
args.push('--verbose');
}
args.push(...paths);
return spawnProcess(TWINE_BIN, args);
}

/**
Expand Down
Loading