Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jan 8, 2026

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- [Trace Metrics 18] Add unit tests for Metrics ([#5005](https://github.com/getsentry/sentry-java/pull/5005))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against a79f91b

Copy link
Member Author

adinauer commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 254.18 ms 284.29 ms 30.11 ms
Size 1.58 MiB 2.20 MiB 635.45 KiB

Baseline results on branch: 12-22-remove_experimental_annotation_from_metrics_options

Startup times

Revision Plain With Sentry Diff
1082fd5 320.80 ms 422.08 ms 101.28 ms

App size

Revision Plain With Sentry Diff
1082fd5 1.58 MiB 2.13 MiB 560.95 KiB

Previous results on branch: 01-05-add_unit_tests_for_metrics

Startup times

Revision Plain With Sentry Diff
e44ae8c 361.45 ms 422.88 ms 61.43 ms

App size

Revision Plain With Sentry Diff
e44ae8c 1.58 MiB 2.13 MiB 560.95 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adinauer adinauer force-pushed the 01-05-add_unit_tests_for_metrics branch from 5ea89f4 to a79f91b Compare January 9, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants