Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jan 9, 2026

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- [Trace Metrics 24] PR Feedback ([#5013](https://github.com/getsentry/sentry-java/pull/5013))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against f502ffe

This was referenced Jan 9, 2026
Copy link
Member Author

adinauer commented Jan 9, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@adinauer adinauer changed the title Final keyword in Metrics methods feat(metrics): [Trace Metrics 24] PR Feedback Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 327.59 ms 385.98 ms 58.39 ms
Size 1.58 MiB 2.20 MiB 635.32 KiB

Baseline results on branch: 01-08-add_e2e_tests_for_metrics

Startup times

Revision Plain With Sentry Diff
527a476 352.67 ms 429.67 ms 77.00 ms

App size

Revision Plain With Sentry Diff
527a476 1.58 MiB 2.13 MiB 561.00 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants