improve filters#454
Merged
Merged
Conversation
Closed
nikgraf
force-pushed
the
ng/improve-filters
branch
from
dd885e7 to
55d04c7
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves filter logic to match public filter logic by restricting logical operators ('not', 'or') to only be allowed at the cross-field level, preventing their use within individual field filters.
- Adds validation to throw errors when logical operators are used at the field level
- Removes the 'and' operator restriction and simplifies filter evaluation logic
- Improves error handling by re-throwing filter validation errors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/hypergraph/src/entity/findMany.ts | Updates filter evaluation logic to restrict logical operators and improves error handling |
| packages/hypergraph/test/entity/findMany.test.ts | Adds new test cases for field-level logical operator validation and updates existing tests |
| .changeset/mighty-numbers-run.md | Adds changeset documentation for the filter logic improvements |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rework filter logic to match public filter logic
follow up to #442