Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SQLModel dependency and refactor URL models
sqlmodeldependency topyproject.toml.schemas.pyfile.main.pyto reflect the new model locations. --@iamserdaThis pull request updates the pre-commit and type checking configuration, adds a new dependency, and refactors model imports and file structure for better organization. The most significant changes are grouped below:
Pre-commit and Type Checking Improvements:
mypypre-commit hook in.pre-commit-config.yamlto usepoetry run mypywith system language and project root as the target, improving consistency with the project's dependency management.Makefileso that thetypechecktarget runsmypyvia pre-commit, and improved theprecommittarget to echo a success message instead of running pre-commit redundantly.rufftarget from theMakefileto streamline linting commands.Dependency Management:
sqlmodelas a new dependency inpyproject.toml, preparing the project for SQL modeling.Model Refactoring and File Structure:
src/models/main.pytosrc/models/schemas.py, removed unused models (ShortiLink,ClickEvent), and updated imports insrc/app/main.pyto reflect this change, clarifying the distinction between schema and other model types. [1] [2]