Skip to content

refactor: Pre-commit and Type Checking Improvements #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamserda merged 1 commit into from
Feb 12, 2026
Merged

refactor: Pre-commit and Type Checking Improvements #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ repos:
rev: v1.19.1
hooks:
- id: mypy
args: [--pretty, --show-error-codes, --check-untyped-defs]
name: poetry-mypy
entry: poetry run mypy
language: system
types: [python]
pass_filenames: false
args: [--pretty, --show-error-codes, --check-untyped-defs,'.']

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.15.0
Expand Down
7 changes: 2 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ activate_venv:
install:
poetry install

ruff:
poetry run pre-commit run ruff

fmt format:
poetry run pre-commit run ruff-format

Expand All @@ -29,10 +26,10 @@ test:
poetry run pytest -q

typecheck:
poetry run mypy .
poetry run pre-commit run -v mypy

precommit: lint format typecheck test
poetry run pre-commit run
@echo "precommit checks passed"

precommit-all: lint format typecheck test
poetry run pre-commit run --all-files
Expand Down
Loading