Skip to content

fix(release): electron-builder の不正な zip 位置引数を削除#190

Merged
shomatan merged 1 commit into
mainfrom
chore/fix-release-electron-builder-zip
May 13, 2026
Merged

fix(release): electron-builder の不正な zip 位置引数を削除#190
shomatan merged 1 commit into
mainfrom
chore/fix-release-electron-builder-zip

Conversation

@shomatan
Copy link
Copy Markdown
Collaborator

概要

v1.2.0 タグ push でトリガーした release.yml が Package .app (arm64 zip) step で
electron-builder: Unknown argument: zip により exit 1。

原因

packages/desktop/electron-builder.ymlmac.target で既に dmg + zip + arm64 を
定義済みのため、CLI に zip を末尾の位置引数として渡す必要がない。
electron-builder 25.x の yargs は target 名を位置引数で受けず弾く。

修正

electron-builder --mac --arm64 zipelectron-builder --mac --arm64 に変更。
config 側で zip は自動生成される。zip 成果物の欠落は下流 Compute artifact metadata
step が ls packages/desktop/release/Ark-*-arm64.zip で検出して fail する。

マージ後

main HEAD で v1.2.0 タグを再作成・push して release.yml を再走させる。

関連

target/arch は electron-builder.yml の mac.target で定義済み。
CLI に `zip` を位置引数で渡すと electron-builder 25.x の yargs が
`Unknown argument: zip` で exit 1 する。v1.2.0 release ビルドが
これで失敗していた。
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Warning

Rate limit exceeded

@shomatan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 3 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 93a90fbe-d6ae-466e-b474-b3c838bf20b7

📥 Commits

Reviewing files that changed from the base of the PR and between 759c44c and f620b0a.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-release-electron-builder-zip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant