Skip to content

Move .plugged to addons/gd-plug/.plugged #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jack-023 wants to merge 2 commits into from
Closed

Move .plugged to addons/gd-plug/.plugged #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f41325
Move .plugged to addons/gd-plug/.plugged
Jack-023 Jul 22, 2024
b45809a
Fix include / exclude options.
Jack-023 Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ func _on_plugin_updated(plugin):

## Known Limitations

- Godot always show errors from plugin repositories in `./plugged` even with `.gdignore` (See [#32](https://github.com/imjp94/gd-plug/issues/32))
- Sometimes random .import files will be unable to remove, while the reason behind it still remains unknown.
- Workaround: Read output for those .import files that failed to remove, and manually delete them.
- `autoload` script references in project setting are not cleared as plugin uninstalled.
Expand Down
8 changes: 5 additions & 3 deletions addons/gd-plug/plug.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ signal updated(plugin)

const VERSION = "0.2.6"
const DEFAULT_PLUGIN_URL = "https://git::@github.com/%s.git"
const DEFAULT_PLUG_DIR = "res://.plugged"
const DEFAULT_PLUG_DIR = "res://addons/gd-plug/.plugged"
const DEFAULT_CONFIG_PATH = DEFAULT_PLUG_DIR + "/index.cfg"
const DEFAULT_USER_PLUG_SCRIPT_PATH = "res://plug.gd"
const DEFAULT_BASE_PLUG_SCRIPT_PATH = "res://addons/gd-plug/plug.gd"
Expand Down Expand Up @@ -594,10 +594,12 @@ func directory_copy_recursively(from, to, args={}):
dest_files += directory_copy_recursively(source, dest, args)
else:
for include_key in include:
if include_key in source:
var include_path = DEFAULT_PLUG_DIR + "/" + include_key
if include_path in source:
var is_excluded = false
for exclude_key in exclude:
if exclude_key in source:
var exclude_path = DEFAULT_PLUG_DIR + "/" + exclude_key
if exclude_path in source:
is_excluded = true
break
if not is_excluded:
Expand Down