[IMP]google_tag_manager_advanced_tracking, facebook_pixel_tracking#451
Closed
JrAdhoc wants to merge 1 commit intoingadhoc:18.0from
Closed
[IMP]google_tag_manager_advanced_tracking, facebook_pixel_tracking#451JrAdhoc wants to merge 1 commit intoingadhoc:18.0from
JrAdhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Este PR ajusta el payload de eCommerce enviado a Google Tag Manager (GTM) para separar explícitamente shipping y discount de la lista de items, alineando mejor el tracking con escenarios de líneas de envío y líneas de recompensa/descuento.
Changes:
- Se agrega el flag
is_reward_lineen la información de checkout por línea para poder excluir/reagrupar líneas de descuento en frontend. - En
prepare_purchase_information()se separan líneas de descuento (reward) y envío (delivery) para enviarlas comodiscountyshipping, excluyéndolas deitems. - En JS, el evento
begin_checkoutfiltra líneas reward, calculadiscounty envíaitemssin reward lines; además evita error cuando no existe#cart_products.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| website_sale_advanced_tracking/models/sale_order_line.py | Añade is_reward_line al payload de checkout por línea. |
| website_sale_advanced_tracking/models/sale_order.py | Separa shipping/discount de items al preparar la info de compra. |
| google_tag_manager_advanced_tracking/static/src/js/website_sale_tracking.js | Ajusta begin_checkout para excluir reward lines y mandar discount; añade guard contra #cart_products inexistente. |
9d18744 to
8fc82f9
Compare
8fc82f9 to
9e08687
Compare
…arated from items / fix facebook pixel tracking #115773
9e08687 to
e7ed3d5
Compare
Contributor
|
@roboadhoc r+ bump |
roboadhoc
pushed a commit
that referenced
this pull request
May 5, 2026
…arated from items / fix facebook pixel tracking #115773 closes #451 Signed-off-by: Manuela Cepeda <cem@adhoc.com.ar>
roboadhoc
added a commit
that referenced
this pull request
May 5, 2026
…website_sale_advanced_tracking 18.0.1.3.0, facebook_pixel_tracking 18.0.1.1.0 Merged: #451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

google_tag_manager_advanced_tracking:
discountfacebook_pixel_tracking:
website_sale_advanced_tracking (shared):