Skip to content

Make root lint gate pass#134

Open
mmkal wants to merge 5 commits into
clawpatch/root-pg-testsfrom
clawpatch/root-lint-scope
Open

Make root lint gate pass#134
mmkal wants to merge 5 commits into
clawpatch/root-pg-testsfrom
clawpatch/root-lint-scope

Conversation

@mmkal
Copy link
Copy Markdown
Collaborator

@mmkal mmkal commented May 19, 2026

Summary

Makes the root pnpm lint gate pass on the intended repository surface.

The lint scope now ignores pg vendored sources and copied/demo SQL fixture paths that are not maintained query sources with generated manifests. Maintained-source lint failures are fixed directly by removing repo-forbidden readonly from source-facing types and dropping stale eslint-disable comments for rules this repo does not configure.

While validating the branch, pnpm typecheck exposed a stale pg test fixture missing generate.casing; this PR includes that one-line config correction so the quality gate stays green.

Stack

Base: #133 (clawpatch/root-pg-tests)

Clawpatch

Finding fixed: fnd_sig-feat-release-4862937c51-b1e9_003fc4b337

Shared state directory used locally: /Users/mmkal/src/sqlfu/.clawpatch

Revalidation result: fixed

Validation

pnpm lint
pnpm typecheck
pnpm exec oxfmt --check eslint.config.js packages/pg/src/impl/scratch-database.ts packages/pg/src/impl/typegen.ts packages/pg/test/typegen.test.ts packages/sqlfu/src/dialect.ts packages/ui/src/client.tsx tasks/clawpatch-root-lint-scope.md

Note

Low Risk
Low risk: changes are lint-scope adjustments and minor type/test/UI cleanup with no behavior-impacting logic changes expected.

Overview
Makes the root pnpm lint quality gate pass by expanding ESLint ignores to exclude pg vendored sources and copied/demo SQL fixtures that aren’t maintained inputs.

Fixes maintained-source lint failures by removing repo-forbidden readonly from dialect/typegen handle types (MaterializedTypegenSchema, pg temp DB/typegen handles), dropping stale eslint-disable comments in the UI grid cell templates, and updating the pg typegen test fixture to include generate.casing: 'camel' so pnpm typecheck stays green. Adds a small task writeup documenting the Clawpatch finding + validation.

Reviewed by Cursor Bugbot for commit 67a6b33. Bugbot is set up for automated code reviews on this repo. Configure here.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 19, 2026

Open in StackBlitz

npm i https://pkg.pr.new/sqlfu@134

commit: 67a6b33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant