Make root lint gate pass#134
Open
mmkal wants to merge 5 commits into
Open
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the root
pnpm lintgate pass on the intended repository surface.The lint scope now ignores pg vendored sources and copied/demo SQL fixture paths that are not maintained query sources with generated manifests. Maintained-source lint failures are fixed directly by removing repo-forbidden
readonlyfrom source-facing types and dropping staleeslint-disablecomments for rules this repo does not configure.While validating the branch,
pnpm typecheckexposed a stale pg test fixture missinggenerate.casing; this PR includes that one-line config correction so the quality gate stays green.Stack
Base: #133 (
clawpatch/root-pg-tests)Clawpatch
Finding fixed:
fnd_sig-feat-release-4862937c51-b1e9_003fc4b337Shared state directory used locally:
/Users/mmkal/src/sqlfu/.clawpatchRevalidation result:
fixedValidation
pnpm lint pnpm typecheck pnpm exec oxfmt --check eslint.config.js packages/pg/src/impl/scratch-database.ts packages/pg/src/impl/typegen.ts packages/pg/test/typegen.test.ts packages/sqlfu/src/dialect.ts packages/ui/src/client.tsx tasks/clawpatch-root-lint-scope.mdNote
Low Risk
Low risk: changes are lint-scope adjustments and minor type/test/UI cleanup with no behavior-impacting logic changes expected.
Overview
Makes the root
pnpm lintquality gate pass by expanding ESLintignoresto exclude pg vendored sources and copied/demo SQL fixtures that aren’t maintained inputs.Fixes maintained-source lint failures by removing repo-forbidden
readonlyfrom dialect/typegen handle types (MaterializedTypegenSchema, pg temp DB/typegen handles), dropping staleeslint-disablecomments in the UI grid cell templates, and updating the pg typegen test fixture to includegenerate.casing: 'camel'sopnpm typecheckstays green. Adds a small task writeup documenting the Clawpatch finding + validation.Reviewed by Cursor Bugbot for commit 67a6b33. Bugbot is set up for automated code reviews on this repo. Configure here.