Skip to content

Use portable atomic, remove explicit/redundant feature declaration & move to edition 2021#103

Closed
ithinuel wants to merge 3 commits intojamesmunns:mainfrom
ithinuel:use-portable-atomic
Closed

Use portable atomic, remove explicit/redundant feature declaration & move to edition 2021#103
ithinuel wants to merge 3 commits intojamesmunns:mainfrom
ithinuel:use-portable-atomic

Conversation

@ithinuel
Copy link
Collaborator

No description provided.

@ithinuel ithinuel force-pushed the use-portable-atomic branch 3 times, most recently from 75046d1 to 068dae0 Compare November 26, 2023 23:44
@ithinuel ithinuel force-pushed the use-portable-atomic branch from 6b5ac37 to 54dfe17 Compare December 6, 2023 00:36
@mfp20
Copy link

mfp20 commented Aug 23, 2024

Please merge this pull request to enable use for AVR and other archs. It externalizes the management of missing atomics to specialized crate (portable-atomic).

@Sympatron
Copy link
Collaborator

I would keep the defmt_0_3 feature, because defmt v1 will be released soon and can be supported simultaneously that way.

@jamesmunns: Is bbqueue still maintained or should it be forked for future development?

@jamesmunns
Copy link
Owner

@Sympatron I'm not actively maintaining it at the moment, I've added @ithinuel as a maintainer, but I think they are busy as well.

If you'd like to be added as a maintainer, I'd be happy to add you.

@Sympatron
Copy link
Collaborator

That would be nice. I would like to help maintain bbqueue if you two are short on time.

@jamesmunns
Copy link
Owner

@Sympatron sent you an invite! Feel free to merge PRs as you see fit. Feel free to ping me if you want to coordinate a release.

@Sympatron
Copy link
Collaborator

@ithinuel Are you ok with me making changes to this PR to resolve conflicts? And as I said, I would like to keep the defmt_0_3 feature. Or do you want to do it yourself?

@ithinuel
Copy link
Collaborator Author

ithinuel commented Feb 8, 2025

Sorry for the slow reply.
Yes I am.

@ggriffiniii
Copy link

I came looking to do the same thing. Sounds like there aren't any objections to merging this. @Sympatron is there anything I could do to help get this merged? I would like to use bbqueue in my project and this is blocking me.

@jamesmunns
Copy link
Owner

@ggriffiniii I would strongly recommend checking out bbq2. See #107. If you are on a platform with no atomics, bbq2 will work much better than emulated portable atomics, because otherwise you will take multiple critical sections for every transaction.

If there are no objections and the other maintainers are busy, I'm going to just merge bbq2 into bbqueue and maintain that instead.

@ggriffiniii
Copy link

Thanks for the pointer. Yes, indeed bbq2 seems like it does exactly what I'm looking for.

@jamesmunns
Copy link
Owner

Closing this as superceded by bbq2 and the merge in #110. I will be making a new release of bbqueue in the near future, by subbing in the bbq2 implementation.

@jamesmunns jamesmunns closed this Jan 4, 2026
@Sympatron Sympatron mentioned this pull request Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants