docs(rfc-008): P4d S7 phase index + Principle 12 record P4d (closes #403)#418
Merged
Conversation
) Refresh RFC-008 phase docs to record P4d (S1-S6 + ESC merged, S7-S8 open); fix stale P2/P3 queued ledger stubs in the RFC body; add a CI guard rejecting stale P4b phase status; note per-project uninstall implemented in Principle 12. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lantiscooperdev
left a comment
Collaborator
There was a problem hiding this comment.
Rule 17 bot review — RFC-008 P4d S7 (PR #418): ACCEPT-with-FU
Substantive review of the S7 docs-sync slice (RFC-008 phase index + Principle 12 record P4d, closes #403).
Verdict trail
| Round | Scope | Verdict | Reply episode |
|---|---|---|---|
| 1 | negative-scenario-reviewer (docs completeness + CI guard) | ACCEPT-with-FU (0 blockers) | 20260621-130119-accept-with-fu-rfc-008-p4d-s7-docs-sync--36f2 |
Findings (resolved in commit 0dbcdc2)
| Finding | Class | Resolution |
|---|---|---|
| F1 | MAJOR | CI guard was scoped to docs/rfcs/RFC-008 (subdir) and missed the RFC body sibling file. Widened to docs/rfcs/RFC-008* (subdir + body). Fixed inline. |
| F2 | MINOR | Narrow regex residual (misses non-P4b spellings / cross-line). Kept as the #403 closer; documented, not chasing broader regexes (stopping-rule). |
| F3 | NIT | The em-dash on the touched PRINCIPLES.md line is pre-existing (unchanged clause); the added text introduces none. |
Independently re-verified
- CI guard red-then-green: stale
P4b reduced E2E + cutover remainsmatched the regex; post-fix grep overdocs/rfcs/RFC-008*returns nothing. PASS. - PR-to-slice mappings (#400/#401/#402, #409, #416, #417; P2 #381/#384/#388; P3 #389/#391/#392/#393/#395) match git history + workplan v145. PASS.
- "Original P4b superseded by P4d": no P4b commit exists; the workplan recorded the fold-in. Defensible. PASS.
- PRINCIPLES round-trip claim:
tests/test-uninstall-enforcement.mjsexists and asserts core + enforce + uninstall == core. PASS. - Rule-10 index consistency: README +
_index.jsonRFC-008 = accepted (no change); no stale P4 status elsewhere (summary table, crosswalk, traceability matrix, CAPABILITIES). PASS.
Follow-ups (Rule 18 step 9)
- None deferred. P2/P3 ledger staleness + F1 handled inline. The process miss (in-cycle review skipped until prompted) is logged as local violation
20260621-130517-skipped-rule-18-step-6-adversarial-code--a5ed.
What your approval is checking
Per Rule 17, your UI approval is the review-required gate. The substantive review is complete (ACCEPT-with-FU, F1 fixed). Please do a final read of the diff and approve (or HOLD) in the GitHub UI.
Posted by lantiscooperdev (bot account), Claude Opus 4.8 (1M context).
lantiscooperdev
approved these changes
Jun 21, 2026
lantiscooperdev
pushed a commit
that referenced
this pull request
Jun 22, 2026
S7 (#418) and S8 (#419) are merged, completing P4d and therefore P4 (P4a #397 + P4c #398 + P4d S1-S8 all merged). Flips the stale 'S7-S8 open' / 'IN PROGRESS' status in the RFC body ledger (:1216), the RFC-008/README.md phase matrix (:21), and P4-enforce-config.md status line + the S7/S8 slice-table rows. Rule 10 doc-sync; no code change. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S7 — RFC-008 P4d phase index + Principle 12 record P4d
Docs-only slice. Records the P4d per-project enforcement re-architecture in the RFC-008 phase docs and Principle 12, removes the stale "P4b ... remains" claim, and adds a CI guard against regression. Closes #403.
Changes
docs/rfcs/RFC-008/README.md— P4 row: P4a feat(rfc-008): P4a — per-project enforce-config wired into the 3 pre_tool_use gates #397 + P4c RFC-008 P4c: layer-wide active:false enforcement kill switch #398 done; P4d S1-S6 + ESC merged, S7-S8 open; original P4b superseded by P4d.docs/rfcs/RFC-008/P4-enforce-config.md— Status line refreshed + a P4d slice table (S1-S4 test(rfc-008): P4d S1 — mock-project activation-scoping E2E harness #400/feat(rfc-008): P4d S2 — per-project enforcement install (--install-enforcement) + substrate allowlist #401/feat(rfc-008): P4d S4 — provision per-project enforce-config.json switch (invariant 2) #402, ESC feat(rfc-008): P4d ESC — gates block ONLY repo-source writes (R1/R2/R3) #409, S5 feat(rfc-008): P4d S5 — install.mjs --uninstall-enforcement [--purge-config] #416, S6 feat(rfc-008): P4d S6 seed-identity coupling guard (REQ-7) #417 merged; S7 in progress; S8 open).docs/rfcs/RFC-008-decouple-enforcement-from-substrate.md— body ledger: P2 and P3queuedtoDONE, P4queuedtoIN PROGRESS(pre-existing staleness beyond docs(rfc-008): refresh phase index for P4d (S1–S4 done) at P4d completion #403, folded in per Rule 10).PRINCIPLES.md§12 — records per-project uninstall implemented (P4d S5 feat(rfc-008): P4d S5 — install.mjs --uninstall-enforcement [--purge-config] #416) + the asserting test..github/workflows/rfc-validate.yml— CI step rejecting staleP4b.*(remains|reduced|cutover)underdocs/rfcs/RFC-008*(covers the subdir + the RFC body file).Review (Rule 18 step 6)
negative-scenario-reviewer: ACCEPT-with-FU, 0 blockers.docs/rfcs/RFC-008*).Verification
P4b reduced E2E + cutover remainsmatched the regex; post-editgrep -rnE "P4b.*(remains|reduced|cutover)" docs/rfcs/RFC-008*returns nothing.Closes #403.
Generated with Claude Code