[FindGRPC.cmake] Make sure that PACKAGE_VERSION is not overwritten when doing find_package(gRPC)
#173115
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when doing `find_package(gRPC)` `PACKAGE_VERSION` is important since it sets the `LLVM_VERSION_STRING` string.
cachemeifyoucan
approved these changes
Dec 19, 2025
Collaborator
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
Confirm I have PACKAGE_VERSION overwrite in my version of c-ares-config-version.cmake as well.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PACKAGE_VERSIONis important since it sets theLLVM_VERSION_STRINGstring.