Skip to content

[FindGRPC.cmake] Make sure that PACKAGE_VERSION is not overwritten when doing find_package(gRPC) #173115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akyrtzi merged 1 commit into from
Dec 20, 2025
Merged

[FindGRPC.cmake] Make sure that PACKAGE_VERSION is not overwritten when doing find_package(gRPC) #173115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmake/Modules/FindGRPC.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ find_package(Threads REQUIRED)
set(protobuf_MODULE_COMPATIBLE TRUE)
find_package(Protobuf CONFIG HINTS ${GRPC_INSTALL_PATH})
message(STATUS "Using protobuf ${Protobuf_VERSION}")
# There's a `c-ares` library whose CMake file sets the `PACKAGE_VERSION` variable.
# Preserve the original `PACKAGE_VERSION` value and restore it.
set(PACKAGE_VERSION_PREV "${PACKAGE_VERSION}")
find_package(gRPC CONFIG HINTS ${GRPC_INSTALL_PATH})
set(PACKAGE_VERSION "${PACKAGE_VERSION_PREV}")
message(STATUS "Using gRPC ${gRPC_VERSION}")

if (Protobuf_FOUND AND gRPC_FOUND)
Expand Down
Loading