Conversation
There was a problem hiding this comment.
Kudos for tackling this proactively @Pive01 - LGTM! 🚀 Gave it a quick try locally right now, and seems to work like a charm. 👌 (installing the Extension in dev mode, and then accessing it via https://aws-proxy.localhost.localstack.cloud:4566)
Regarding the failed build - not sure what's going on here, maybe the LOCALSTACK_AUTH_TOKEN is configured incorrectly in the CI environment, or the auth token / license is expired. Will try to look into that shortly! 👀
7924117 to
a16a884
Compare
a16a884 to
bda9732
Compare
7077afe to
2eaa33e
Compare
|
@Pive01 FYI, there were some library dependency issues with recent dev releases (e.g., The issue should be now fixed, builds are green again 🟢 - I took the liberty of pushing a small change in the CI build config directly to the branch. 👍 (Let me know once merged, happy to do a new pypi release of the library with the latest version.) |
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
Motivation
Reports found out that when using the extension in the web application with dark theme is quite difficult to read what is going on
After little research I've found out that the extension does not use our WebApp pattern that not only fixes the issue but also provides other quality of life improvements, especially when displayed inside the WebApp.
What I did was mostly create a blank extension and adapting this one based on the setup of the blank one (that uses our react template)
This is the result AFTER the changes
I also took some liberties in refactoring a bit the UI
Todo
Before merging we still need to deploy a fix I've discovered in the web app for the integration package https://github.com/localstack/localstack-web/pull/2063
Note
After setting the env vars and the proxy config I could see the emulator saying that the proxy has started but from the UI it kept saying disabled... This is however in line on how it was working before so I beliee I didn't introduce any regressions... let me know if you want me to dig a bit deeper into this
Related
Closes BEE-262