fix: grab frame button ignores crop, scale, and rotate edits#909
Open
Nightcoder-26 wants to merge 1 commit into
Open
fix: grab frame button ignores crop, scale, and rotate edits#909Nightcoder-26 wants to merge 1 commit into
Nightcoder-26 wants to merge 1 commit into
Conversation
The 'Grab Frame' feature previously drew the raw video element directly onto a canvas, completely ignoring any zoom, crop, rotation, or aspect ratio changes the user applied in the UI. Fix: Replaced the manual canvas drawing logic with the existing 'captureFrameAsPng' utility from frame-export.ts, which correctly computes and applies all recipe transformations before rendering the image.
|
Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Nightcoder-26!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Contributor
✅ PR Format Check Passed — @Nightcoder-26Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Author
|
@magic-peach kindly review the PR and merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the "Grab Frame" button completely ignored all user edits (such as cropping, zooming, rotating, or aspect ratio changes) and instead downloaded the raw, original video frame directly from the
Fix: Replaced the manual canvas drawing logic inside VideoPreview.tsx with the existing captureFrameAsPng(video, recipe) utility from frame-export.ts. This utility correctly computes and applies all recipe transformations (scale, rotation, crop dimensions) to the canvas before saving the PNG.
Related Issue
fixes #905
Type of Contribution
Participant Info
Screen Recording
Recording.2026-05-22.130756.mov
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in