Skip to content

fix: grab frame button ignores crop, scale, and rotate edits #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nightcoder-26 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: grab frame button ignores crop, scale, and rotate edits #909

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f3c799
fix: grab frame button ignores crop, scale, and rotate edits
May 22, 2026
77de7e0
Merge remote-tracking branch 'origin/main' into fix-grab-frame-edits
May 24, 2026
f867ba5
fix: remove duplicate URL.revokeObjectURL call in file effect
May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 10 additions & 21 deletions src/components/VideoPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import { useEffect, useRef, useState, useCallback, RefObject } from "react";
import { EditRecipe, TextOverlay } from "@/lib/types";
import { getPresetById } from "@/lib/presets";
import { captureFrameAsPng } from "@/lib/frame-export";
import { cn } from "@/lib/utils";
import { Camera } from "lucide-react";
import ComparisonPreview from "./ComparisonPreview";
Expand Down Expand Up @@ -38,39 +39,27 @@ export default function VideoPreview({
const previewContainerRef = useRef<HTMLDivElement>(null);
const onLoadedRef = useRef<(() => void) | null>(null);

const handleGrabFrame = useCallback(() => {
/** Capture the current video frame and download it as a PNG. */
const handleGrabFrame = useCallback(async () => {
const video = videoRef.current;
if (!video || video.readyState < 2) return;

const canvas = document.createElement("canvas");
canvas.width = video.videoWidth;
canvas.height = video.videoHeight;

const ctx = canvas.getContext("2d");
if (!ctx) return;
ctx.drawImage(video, 0, 0, canvas.width, canvas.height);

canvas.toBlob((blob) => {
if (!blob) return;

const totalSec = Math.floor(video.currentTime);
const mins = String(Math.floor(totalSec / 60)).padStart(2, "0");
const secs = String(totalSec % 60).padStart(2, "0");
const filename = `frame-${mins}m${secs}s.png`;
if (!video || video.readyState < 2 || !recipe) return;

try {
const { blob, filename } = await captureFrameAsPng(video, recipe);
const url = URL.createObjectURL(blob);
const a = document.createElement("a");
a.href = url;
a.download = filename;
a.click();
URL.revokeObjectURL(url);
}, "image/png");
}, [videoRef]);
} catch (err) {
console.error("Failed to capture frame:", err);
}
}, [videoRef, recipe]);

useEffect(() => {
if (!file) return;

if (urlRef.current) URL.revokeObjectURL(urlRef.current);
setIsLoading(true);
const id = ++lastId.current;
const url = URL.createObjectURL(file);
Expand Down