C: Use more sensible start capacity for hb_array#1381
Open
timkaechele wants to merge 1 commit intomarcoroth:mainfrom
Open
C: Use more sensible start capacity for hb_array#1381timkaechele wants to merge 1 commit intomarcoroth:mainfrom
hb_array#1381timkaechele wants to merge 1 commit intomarcoroth:mainfrom
Conversation
timkaechele
force-pushed
the
lazy-errors-initialization
branch
from
a6b4334 to
bb65e14
Compare
marcoroth
reviewed
Mar 19, 2026
|
|
||
| if (array->capacity == 0) { | ||
| new_capacity = 1; | ||
| new_capacity = 8; |
Owner
There was a problem hiding this comment.
I'm wondering if this is really the right approach. Ideally we could have a lazy and/or shared empty array that only uses memory once for all instances. And only when we try to append errors, we convert it to a proper full array with a capacity. Otherwise on the happy path we would allocate a lot of memory that is never going to be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the start capacity of an array that previously had no capacity.
Instead of using 1, which only allocates a single slot, we allocate 8, which allows more room to grow.
Given that the
hb_arrayonly holds pointers to its items, the memory usage is negligible.