Parser: Add transform_conditionals option for postfix conditionals#1560
Merged
Parser: Add transform_conditionals option for postfix conditionals#1560
transform_conditionals option for postfix conditionals#1560Conversation
github-actions
bot
added
parser
ruby
wasm
typescript
c
playground
c-extension
rbs
rubygem
rust
java
core
cpp
labels
marcoroth
force-pushed
the
parser-transform_conditionals
branch
from
deab56e to
a260c29
Compare
marcoroth
force-pushed
the
parser-transform_conditionals
branch
from
a260c29 to
668c77d
Compare
marcoroth
force-pushed
the
parser-transform_conditionals
branch
from
f1416c1 to
8b4a6da
Compare
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
marcoroth
changed the title
transform_conditionals parser optiontransform_conditionals parser option for postfix conditionals
marcoroth
changed the title
transform_conditionals parser option for postfix conditionalstransform_conditionals option for postfix conditionals
marcoroth
added a commit
that referenced
this pull request
Apr 5, 2026
This pull request extends `transform_conditionals` to handle ternary expressions (`condition ? 'yes' : 'no'`) in ERB output tags, transforming them into `ERBIfNode`/`ERBElseNode` structures. The following: ```erb <%= condition ? 'yes' : 'no' %> ``` is transformed to the equivalent with `transform_conditionals: true`: ```erb <% if condition %><%= 'yes' %><% else %><%= 'no' %><% end %> ``` This also works inside attribute values, open tags, and nested within postfix conditionals: ```erb <%= (condition? ? "true" : "false") if another_condition? %> ``` becomes: ```erb <% if another_condition? %><% if condition? %><%= "true" %><% else %><%= "false" %><% end %><% end %> ``` The ternary transform is split into its own file (`ternary_conditionals.c`) separate from the postfix conditional transform (`postfix_conditionals.c`). The `transform_ternary_expression` function is exported so that `postfix_conditionals.c` can call it when a nested ternary is detected inside a postfix body. Follows up on #1560 which added postfix support and intentionally named the option `transform_conditionals` to allow for this extension. A future optimization could be to extract literal values directly as `LiteralNode`s or the proper equivalent. So that: ```erb <%= condition ? 'yes' : 'no' %> ``` could become: ```diff - <% if condition %><%= 'yes' %><% else %><%= 'no' %><% end %> + <% if condition %>yes<% else %>no<% end %> ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
transform_conditionalsparser option that transforms ERB output tags with postfixif/unlessconditionals into properERBIfNode/ERBUnlessNodestructures wrapping the body expression.The following:
is transformed to the equivalent with
transform_conditionals: true:The option is named
transform_conditionals(rather thantransform_postfix) to allow extending it to also handle ternary transformations in the future.Builds on the postfix conditional support added for Action View helpers in #1494, extending it to all ERB output expressions.
The motivation for this is improve the detection of conditionals since they previously weren't surfaced as
ERBIfNodes if they were fully self contained in anERBContentNode. This will also make the static analysis easier when we want get to analyze template dependencies and conditionals for reactivity.