Skip to content

Parser: Properly transform nested render calls#1588

Merged
marcoroth merged 1 commit intomainfrom
transform-nested-render-calls
Apr 3, 2026
Merged

Parser: Properly transform nested render calls#1588
marcoroth merged 1 commit intomainfrom
transform-nested-render-calls

Conversation

@marcoroth
Copy link
Copy Markdown
Owner

@marcoroth marcoroth commented Apr 3, 2026

This pull request updates the parser to properly handle and transform nested render calls with blocks.

The following now gets properly parsed with render_nodes: true:

<%= render LayoutComponent.new do |layout| %>
  <%= render CardComponent.new do |card| %>
    ...
  <% end %>
<% end %>

Previously, the inner render node stayed a ERBBlockNode and wasn't transformed to a ERBRenderNode.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 3, 2026

npx https://pkg.pr.new/@herb-tools/formatter@1588
npx https://pkg.pr.new/@herb-tools/language-server@1588
npx https://pkg.pr.new/@herb-tools/linter@1588

commit: f7ca917

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🌿 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:


🌱 Grown from commit f7ca917


✅ Preview deployment has been cleaned up.

@marcoroth marcoroth merged commit cd4ab75 into main Apr 3, 2026
46 checks passed
@marcoroth marcoroth deleted the transform-nested-render-calls branch April 3, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant