Skip to content

Parser: Properly transform nested render calls #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoroth merged 1 commit into from
Apr 3, 2026
Merged

Parser: Properly transform nested render calls #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion javascript/packages/linter/test/rules/erb-no-unused-expressions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ describe("ERBNoUnusedExpressionsRule", () => {
`)
})

test.skip("passes for method calls on outer block local inside nested render block", () => {
test("passes for method calls on outer block local inside nested render block", () => {
expectNoOffenses(dedent`
<%= render LayoutComponent.new do |layout| %>
<%= render CardComponent.new do |card| %>
Expand Down
1 change: 1 addition & 0 deletions src/analyze/analyze.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,7 @@ hb_array_T* get_node_children_array(const AST_NODE_T* node) {
case AST_ERB_ENSURE_NODE: return ((AST_ERB_ENSURE_NODE_T*) node)->statements;
case AST_ERB_CASE_NODE: return ((AST_ERB_CASE_NODE_T*) node)->children;
case AST_ERB_WHEN_NODE: return ((AST_ERB_WHEN_NODE_T*) node)->statements;
case AST_ERB_RENDER_NODE: return ((AST_ERB_RENDER_NODE_T*) node)->body;
default: return NULL;
}
}
Expand Down
11 changes: 11 additions & 0 deletions test/analyze/render_block_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,5 +172,16 @@ class RenderBlockTest < Minitest::Spec
<% end %>
HTML
end

test "nested render blocks" do
assert_parsed_snapshot(<<~HTML, render_nodes: true)
<%= render LayoutComponent.new do |layout| %>
<%= render CardComponent.new do |card| %>
<% layout.with_sidebar %>
<% card.with_header %>
<% end %>
<% end %>
HTML
end
end
end
130 changes: 130 additions & 0 deletions ...ested_render_blocks_b15a799fdd21ef9c94eba2aa044b3407-f8009707a6f8814717b65550c888710c.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading