chore: Remove unused parameters and definitions from main.parameters.json #369
Open
Harmanpreet-Microsoft wants to merge 7 commits intodevfrom
Open
chore: Remove unused parameters and definitions from main.parameters.json #369Harmanpreet-Microsoft wants to merge 7 commits intodevfrom
Harmanpreet-Microsoft wants to merge 7 commits intodevfrom
Conversation
…d main.waf.parameters.json
Harmanpreet-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Harmanpreet-Microsoft
had a problem deploying
to
production
GitHub Actions
Failure
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the Azure deployment parameter files by removing legacy/unused parameters so the infra/main*.parameters.json inputs better match the current Bicep template surface area and reduce configuration noise.
Changes:
- Removed legacy backend/frontend “exists” flags and environment-variable definition blocks from both parameter files.
- Removed legacy
principalIdandaiModelDeploymentsparameter entries from both parameter files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
infra/main.parameters.json |
Removes a set of legacy parameters to simplify the default deployment parameter set. |
infra/main.waf.parameters.json |
Mirrors the same parameter cleanup for the WAF/production parameter set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
44
to
49
| "vmAdminUsername": { | ||
| "value": "${AZURE_ENV_JUMPBOX_ADMIN_USERNAME}" | ||
| }, | ||
| "vmAdminPassword": { | ||
| "value": "${AZURE_ENV_JUMPBOX_ADMIN_PASSWORD}" | ||
| }, | ||
| "backendExists": { | ||
| "value": "${SERVICE_BACKEND_RESOURCE_EXISTS=false}" | ||
| }, | ||
| "backendDefinition": { | ||
| "value": { | ||
| "settings": [ | ||
| { | ||
| "name": "", | ||
| "value": "${VAR}", | ||
| "_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.", | ||
| "_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR} to use the value of 'VAR' from the current environment." | ||
| }, | ||
| { | ||
| "name": "", | ||
| "value": "${VAR_S}", | ||
| "secret": true, | ||
| "_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.", | ||
| "_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR_S} to use the value of 'VAR_S' from the current environment." | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "frontendExists": { | ||
| "value": "${SERVICE_FRONTEND_RESOURCE_EXISTS=false}" | ||
| }, | ||
| "frontendDefinition": { | ||
| "value": { | ||
| "settings": [ | ||
| { | ||
| "name": "", | ||
| "value": "${VAR}", | ||
| "_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.", | ||
| "_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR} to use the value of 'VAR' from the current environment." | ||
| }, | ||
| { | ||
| "name": "", | ||
| "value": "${VAR_S}", | ||
| "secret": true, | ||
| "_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.", | ||
| "_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR_S} to use the value of 'VAR_S' from the current environment." | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "principalId": { | ||
| "value": "${AZURE_PRINCIPAL_ID}" | ||
| }, | ||
| "aiModelDeployments": { | ||
| "value": [ | ||
| { | ||
| "name": "gpt-4o", | ||
| "model": { | ||
| "name": "gpt-4o", | ||
| "version": "2024-08-06", | ||
| "format": "OpenAI" | ||
| }, | ||
| "sku": { | ||
| "name": "GlobalStandard", | ||
| "capacity": 50 | ||
| } | ||
| } | ||
| ] | ||
| } |
| @@ -58,66 +55,6 @@ | |||
| }, | |||
| "enableScaling": { | |||
| "value": true | |||
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure deployment parameter files under infra/ to simplify configuration by removing previously included (but now unused) parameters and example definitions, and adjusting how AI model deployment configuration is represented.
Changes:
- Removed unused parameters (
backendExists,frontendExists,backendDefinition,frontendDefinition,principalId) from the infra parameter files. - Replaced the previous hard-coded
aiModelDeploymentsexample with a newaiModelDeploymentsentry driven by environment variables. - Kept existing single-model GPT parameters (
gptModel*) alongside the newaiModelDeploymentsarray.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| infra/main.parameters.json | Removes unused parameters; reintroduces aiModelDeployments with a new schema based on env vars. |
| infra/main.waf.parameters.json | Same cleanup as non-WAF parameters; reintroduces aiModelDeployments with the new schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+32
| "aiModelDeployments": { | ||
| "value": [ | ||
| { | ||
| "deploymentType": "${AZURE_ENV_MODEL_DEPLOYMENT_TYPE}", | ||
| "modelName": "${AZURE_ENV_MODEL_NAME}", | ||
| "modelCapacity": "${AZURE_ENV_MODEL_CAPACITY}", | ||
| "modelVersion": "${AZURE_ENV_MODEL_VERSION}" | ||
| } | ||
| ] | ||
| }, |
Comment on lines
55
to
59
| "value": "${AZURE_ENV_JUMPBOX_ADMIN_USERNAME}" | ||
| }, | ||
| "vmAdminPassword": { | ||
| "value": "${AZURE_ENV_JUMPBOX_ADMIN_PASSWORD}" | ||
| }, | ||
| "backendExists": { | ||
| "value": "${SERVICE_BACKEND_RESOURCE_EXISTS=false}" | ||
| }, | ||
| "backendDefinition": { | ||
| "value": { | ||
| "settings": [ | ||
| { | ||
| "name": "", | ||
| "value": "${VAR}", | ||
| "_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.", | ||
| "_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR} to use the value of 'VAR' from the current environment." | ||
| }, | ||
| { | ||
| "name": "", | ||
| "value": "${VAR_S}", | ||
| "secret": true, | ||
| "_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.", | ||
| "_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR_S} to use the value of 'VAR_S' from the current environment." | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "frontendExists": { | ||
| "value": "${SERVICE_FRONTEND_RESOURCE_EXISTS=false}" | ||
| }, | ||
| "frontendDefinition": { | ||
| "value": { | ||
| "settings": [ | ||
| { | ||
| "name": "", | ||
| "value": "${VAR}", | ||
| "_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.", | ||
| "_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR} to use the value of 'VAR' from the current environment." | ||
| }, | ||
| { | ||
| "name": "", | ||
| "value": "${VAR_S}", | ||
| "secret": true, | ||
| "_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.", | ||
| "_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR_S} to use the value of 'VAR_S' from the current environment." | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "principalId": { | ||
| "value": "${AZURE_PRINCIPAL_ID}" | ||
| }, | ||
| "aiModelDeployments": { | ||
| "value": [ | ||
| { | ||
| "name": "gpt-4o", | ||
| "model": { | ||
| "name": "gpt-4o", | ||
| "version": "2024-08-06", | ||
| "format": "OpenAI" | ||
| }, | ||
| "sku": { | ||
| "name": "GlobalStandard", | ||
| "capacity": 50 | ||
| } | ||
| } | ||
| ] | ||
| } |
…n.waf.parameters.json for improved clarity and organization
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Azure deployment parameter files under infra/ to reduce unused configuration and simplify how model deployment settings are represented.
Changes:
- Removes unused parameters related to backend/frontend existence flags, env var definition blocks, and
principalId. - Replaces the previously hard-coded
aiModelDeploymentsentry with an env-var-driven version in both parameter files. - Keeps WAF and non-WAF parameter sets aligned by applying the same cleanup in both files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| infra/main.parameters.json | Removes unused backend/frontend/principal parameters and updates aiModelDeployments to be driven by environment variables. |
| infra/main.waf.parameters.json | Mirrors the same cleanup and updates aiModelDeployments for the WAF parameter set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+27
| "aiModelDeployments": { | ||
| "value": [ | ||
| { | ||
| "name": "${AZURE_ENV_MODEL_NAME}", | ||
| "model": { |
Comment on lines
+23
to
+38
| "aiModelDeployments": { | ||
| "value": [ | ||
| { | ||
| "name": "${AZURE_ENV_MODEL_NAME}", | ||
| "model": { | ||
| "name": "${AZURE_ENV_MODEL_NAME}", | ||
| "version": "${AZURE_ENV_MODEL_VERSION}", | ||
| "format": "OpenAI" | ||
| }, | ||
| "sku": { | ||
| "name": "${AZURE_ENV_MODEL_DEPLOYMENT_TYPE}", | ||
| "capacity": "${AZURE_ENV_MODEL_CAPACITY}" | ||
| } | ||
| } | ||
| ] | ||
| }, |
Comment on lines
+23
to
+27
| "aiModelDeployments": { | ||
| "value": [ | ||
| { | ||
| "name": "${AZURE_ENV_MODEL_NAME}", | ||
| "model": { |
…ers.json and main.waf.parameters.json
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the infra deployment parameter templates to reduce unused configuration and standardize model-related defaults, simplifying how environments are configured for deployments.
Changes:
- Removes unused parameters related to backend/frontend “exists” flags, env var definition blocks, and principalId from the parameter files.
- Adds default values for GPT model parameters (deployment type/name/capacity/version).
- Reintroduces/relocates
aiModelDeploymentswith environment-driven templated values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| infra/main.parameters.json | Removes unused parameters and adds GPT model defaults + aiModelDeployments parameter value template. |
| infra/main.waf.parameters.json | Mirrors the main parameters cleanup and GPT model defaults + aiModelDeployments template for WAF deployments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+24
| "aiModelDeployments": { | ||
| "value": [ |
Comment on lines
17
to
19
| "gptModelCapacity": { | ||
| "value": "${AZURE_ENV_MODEL_CAPACITY}" | ||
| "value": "${AZURE_ENV_MODEL_CAPACITY=150}" | ||
| }, |
Comment on lines
17
to
19
| "gptModelCapacity": { | ||
| "value": "${AZURE_ENV_MODEL_CAPACITY}" | ||
| "value": "${AZURE_ENV_MODEL_CAPACITY=150}" | ||
| }, |
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
|
@Harmanpreet-Microsoft I've opened a new pull request, #370, to work on those changes. Once the pull request is ready, I'll request review from you. |
6 tasks
…aceholders Co-authored-by: Harmanpreet-Microsoft <175086414+Harmanpreet-Microsoft@users.noreply.github.com>
[WIP] Chore: Remove unused parameters and definitions from main.parameters.json
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Harmanpreet-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request simplifies the infrastructure parameter files by removing several unused or redundant parameters related to backend/frontend resource existence, environment variable definitions, principal IDs, and AI model deployments. The changes help streamline deployment configuration and reduce complexity in both
infra/main.parameters.jsonandinfra/main.waf.parameters.json.Parameter cleanup and simplification:
backendExists,frontendExists) from bothinfra/main.parameters.jsonandinfra/main.waf.parameters.jsonto reduce unnecessary configuration. [1] [2] [3]backendDefinition,frontendDefinition) from both parameter files, eliminating unused settings and comments. [1] [2]principalId) from both files, as it is no longer needed for deployment. [1] [2]aiModelDeployments) from both files, streamlining the parameter structure. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information