Skip to content

chore: Remove unused parameters and definitions from main.parameters.json #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harmanpreet-Microsoft wants to merge 7 commits into
base: dev
Choose a base branch
from
+40 −134
Open

chore: Remove unused parameters and definitions from main.parameters.json #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c581e1
Remove unused parameters and definitions from main.parameters.json an…
Harmanpreet-Microsoft Mar 17, 2026
6845243
Add aiModelDeployments parameter to main.parameters.json and main.waf…
Harmanpreet-Microsoft Mar 17, 2026
153f16d
Refactor aiModelDeployments structure in main.parameters.json and mai…
Harmanpreet-Microsoft Mar 17, 2026
0bbf213
Update default values for model deployment parameters in main.paramet…
Harmanpreet-Microsoft Mar 17, 2026
acb562c
Initial plan
Copilot Mar 17, 2026
79b74ea
Fix aiModelDeployments to use concrete defaults instead of env-var pl…
Copilot Mar 17, 2026
d73c877
Merge pull request #370 from microsoft/copilot/sub-pr-369
Harmanpreet-Microsoft Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 20 additions & 67 deletions infra/main.parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,32 @@
"value": "${AZURE_LOCATION}"
},
"gptModelDeploymentType": {
"value": "${AZURE_ENV_MODEL_DEPLOYMENT_TYPE}"
"value": "${AZURE_ENV_MODEL_DEPLOYMENT_TYPE=GlobalStandard}"
},
"gptModelName": {
"value": "${AZURE_ENV_MODEL_NAME}"
"value": "${AZURE_ENV_MODEL_NAME=gpt-4o}"
},
"gptModelCapacity": {
"value": "${AZURE_ENV_MODEL_CAPACITY}"
"value": "${AZURE_ENV_MODEL_CAPACITY=150}"
},
Comment on lines 17 to 19
"gptModelVersion": {
"value": "${AZURE_ENV_MODEL_VERSION}"
"value": "${AZURE_ENV_MODEL_VERSION=2024-08-06}"
},
"aiModelDeployments": {
"value": [
Comment on lines +23 to +24
{
"name": "gpt-4o",
"model": {
Comment on lines +23 to +27
"name": "gpt-4o",
"version": "2024-08-06",
"format": "OpenAI"
},
"sku": {
"name": "GlobalStandard",
"capacity": 150
}
}
]
},
Comment on lines +23 to +38
Comment on lines +23 to +38
"imageVersion": {
"value": "${AZURE_ENV_IMAGETAG=latest}"
Expand Down Expand Up @@ -46,69 +62,6 @@
},
"vmAdminPassword": {
"value": "${AZURE_ENV_JUMPBOX_ADMIN_PASSWORD}"
},
"backendExists": {
"value": "${SERVICE_BACKEND_RESOURCE_EXISTS=false}"
},
"backendDefinition": {
"value": {
"settings": [
{
"name": "",
"value": "${VAR}",
"_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.",
"_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR} to use the value of 'VAR' from the current environment."
},
{
"name": "",
"value": "${VAR_S}",
"secret": true,
"_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.",
"_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR_S} to use the value of 'VAR_S' from the current environment."
}
]
}
},
"frontendExists": {
"value": "${SERVICE_FRONTEND_RESOURCE_EXISTS=false}"
},
"frontendDefinition": {
"value": {
"settings": [
{
"name": "",
"value": "${VAR}",
"_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.",
"_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR} to use the value of 'VAR' from the current environment."
},
{
"name": "",
"value": "${VAR_S}",
"secret": true,
"_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.",
"_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR_S} to use the value of 'VAR_S' from the current environment."
}
]
}
},
"principalId": {
"value": "${AZURE_PRINCIPAL_ID}"
},
"aiModelDeployments": {
"value": [
{
"name": "gpt-4o",
"model": {
"name": "gpt-4o",
"version": "2024-08-06",
"format": "OpenAI"
},
"sku": {
"name": "GlobalStandard",
"capacity": 50
}
}
]
}
}
}
87 changes: 20 additions & 67 deletions infra/main.waf.parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,32 @@
"value": "${AZURE_LOCATION}"
},
"gptModelDeploymentType": {
"value": "${AZURE_ENV_MODEL_DEPLOYMENT_TYPE}"
"value": "${AZURE_ENV_MODEL_DEPLOYMENT_TYPE=GlobalStandard}"
},
"gptModelName": {
"value": "${AZURE_ENV_MODEL_NAME}"
"value": "${AZURE_ENV_MODEL_NAME=gpt-4o}"
},
"gptModelCapacity": {
"value": "${AZURE_ENV_MODEL_CAPACITY}"
"value": "${AZURE_ENV_MODEL_CAPACITY=150}"
},
Comment on lines 17 to 19
"gptModelVersion": {
"value": "${AZURE_ENV_MODEL_VERSION}"
"value": "${AZURE_ENV_MODEL_VERSION=2024-08-06}"
},
"aiModelDeployments": {
"value": [
{
"name": "gpt-4o",
"model": {
Comment on lines +23 to +27
"name": "gpt-4o",
"version": "2024-08-06",
"format": "OpenAI"
},
"sku": {
"name": "GlobalStandard",
"capacity": 150
}
}
]
},
"imageVersion": {
"value": "${AZURE_ENV_IMAGETAG=latest}"
Expand Down Expand Up @@ -47,9 +63,6 @@
"vmAdminPassword": {
"value": "${AZURE_ENV_JUMPBOX_ADMIN_PASSWORD}"
},
"backendExists": {
"value": "${SERVICE_BACKEND_RESOURCE_EXISTS=false}"
},
"enableMonitoring": {
"value": true
},
Expand All @@ -58,66 +71,6 @@
},
"enableScaling": {
"value": true
},
"backendDefinition": {
"value": {
"settings": [
{
"name": "",
"value": "${VAR}",
"_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.",
"_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR} to use the value of 'VAR' from the current environment."
},
{
"name": "",
"value": "${VAR_S}",
"secret": true,
"_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.",
"_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR_S} to use the value of 'VAR_S' from the current environment."
}
]
}
},
"frontendExists": {
"value": "${SERVICE_FRONTEND_RESOURCE_EXISTS=false}"
},
"frontendDefinition": {
"value": {
"settings": [
{
"name": "",
"value": "${VAR}",
"_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.",
"_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR} to use the value of 'VAR' from the current environment."
},
{
"name": "",
"value": "${VAR_S}",
"secret": true,
"_comment_name": "The name of the environment variable when running in Azure. If empty, ignored.",
"_comment_value": "The value to provide. This can be a fixed literal, or an expression like ${VAR_S} to use the value of 'VAR_S' from the current environment."
}
]
}
},
"principalId": {
"value": "${AZURE_PRINCIPAL_ID}"
},
"aiModelDeployments": {
"value": [
{
"name": "gpt-4o",
"model": {
"name": "gpt-4o",
"version": "2024-08-06",
"format": "OpenAI"
},
"sku": {
"name": "GlobalStandard",
"capacity": 50
}
}
]
}
}
}
Loading