feat(events): Phase 3 — rename gRPC ejendom types to property#805
Merged
Conversation
Mirror of Phase 1/2 pattern for the next noun in the opgave→event
migration. Renames the gRPC message types and RPC method names from
Ejendom to Property. Wire field names stay (`ejendom_id`, `ejendomme`)
so generated C# accessors don't churn.
Proto changes:
- rpc ListEjendomme(ListEjendommeRequest) returns (ListEjendommeResponse)
→ rpc ListProperties(ListPropertiesRequest) returns (ListPropertiesResponse)
- message Ejendom → message Property
- message ListEjendommeRequest/Response → ListPropertiesRequest/Response
- Top-of-file comment trimmed to Phase 2's tightened form (after re-gate).
Handler changes (EventsGrpcService.cs):
- public override Task<ListEjendommeResponse> ListEjendomme(...)
→ Task<ListPropertiesResponse> ListProperties(...)
- new Ejendom { ... } → new Property { ... }
- response.Ejendomme.Add(...) kept (generated from carved wire field)
- 16 generated accessors (request.EjendomId reads, EjendomId = ... setters)
untouched — driven by carved wire fields.
Build: dotnet clean + build green (0 errors). Backend restarts cleanly
on :5000+:5001. Embedded copy at eform-angular-frontend synced.
Spec: docs/superpowers/specs/2026-05-11-opgave-to-event-migration.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Phase 3 of the opgave→event migration on the plugin side: renames the gRPC “Ejendom” surface to “Property” (message types + RPC method name) while preserving Danish wire field names to avoid generated accessor churn.
Changes:
- Renamed
ListEjendommeRPC →ListPropertiesand updated the server handler accordingly. - Renamed proto message types
Ejendom→PropertyandListEjendomme*→ListProperties*, keeping wire fields likeejendomme/ejendom_idunchanged.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Services/GrpcServices/EventsGrpcService.cs | Renames the gRPC handler override to ListProperties and returns Property messages while keeping Danish wire-field-backed accessors. |
| eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Protos/events.proto | Renames RPC + message types from Ejendom to Property, preserving wire field names (ejendomme, ejendom_id) per migration strategy. |
…handler
EventsGrpcService.cs imports both BackendConfiguration.Pn.Grpc.Events
(Phase 1 namespace, now contains gRPC Property type after Phase 3 rename)
AND Microting.EformBackendConfigurationBase.Infrastructure.Data.Entities
(base SDK, contains an EF entity called Property). CI build failed with
CS0104: ambiguous reference.
Phase 2's analogous rename (Tavle → Board) didn't trip this because the
base package has no Board entity. Phase 3 is the first time a renamed
gRPC type collides with a base-entity class name.
Fix: fully-qualify the single `new Property { ... }` call site with
`new BackendConfiguration.Pn.Grpc.Events.Property { ... }`. Inline
comment explains the carve-out for future readers.
Local build: `dotnet build` from eFormAPI.Web → 0 errors. Embedded copy
re-synced.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 of the opgave→event migration: rename gRPC message types and RPC method names from Ejendom to Property on the plugin side. Mirrors Phase 1 + Phase 2 pattern — wire field names stay so generated C# accessors don't churn.
Base: `stable` (correcting the Phase 2 oversight that targeted `master` and required a follow-up promotion PR #804).
Spec: `docs/superpowers/specs/2026-05-11-opgave-to-event-migration.md` (Phase 3 subsection).
Renamed (gRPC type / RPC method)
Stayed Danish (CARVE_WIRE_FIELD)
Verification
Coordinated rollout
🤖 Generated with Claude Code