Open
Conversation
Our codebase is heavily biased towards mutable Carbon. Mixing mutable and immutable semantics makes it hard to reason about code. https://gitlab.mll/documentation/coding-guidelines/-/issues/313 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add `disallowedClasses` rule for `Carbon\CarbonImmutable`. BREAKING CHANGE: Requires `spaze/phpstan-disallowed-calls` ^4.4 (dropped ^2). The `rules.neon` is only loaded on PHP 8.0+ anyway, where ^4.4 applies. https://gitlab.mll/documentation/coding-guidelines/-/issues/313 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
spawnia
changed the title
CarbonImmutable via PHPStan
spaze/phpstan-disallowed-calls ^4.4 requires phpstan ^1.12.6, which conflicts with larastan 1.0.4 (phpstan <1.9) on PHP 8.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
spaze/phpstan-disallowed-calls ^4.4 requires phpstan ^1.12.6, which conflicts with larastan 1.0.4 (phpstan <1.9) on PHP 8.0. Include rules.neon based on whether spaze is installed rather than checking the PHP version, so it works regardless of which PHP versions have spaze removed in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simbig
added a commit
that referenced
this pull request
Mar 11, 2026
- Extract actual flowcell ID using nemo's regex (000000000-AGKG7 → AGKG7) - Normalize backslashes so basename() works with Windows paths on Linux - Support 6-digit dates (ymd format, e.g. 151231) alongside 8-digit (Ymd) - Use Carbon instead of CarbonImmutable (aligns with #80) - Remove unused toString() and rawFlowcellSegment (YAGNI) - Add comprehensive test coverage for all Illumina run folder formats Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CarbonImmutableclass usage viadisallowedClassesinrules.neonOur codebase is heavily biased towards mutable
Carbon.Mixing mutable and immutable semantics makes it hard to reason about code.
https://gitlab.mll/documentation/coding-guidelines/-/issues/313
Breaking change
Requires
spaze/phpstan-disallowed-calls^4.4 (dropped ^2).All our projects already require ^4.4, so no migration needed.
Test plan
vendor/bin/phpstan analysepasses