fix wrong base_url in reverse_proxy scenario to connect WSS

[nerzhul]

In reverse proxy scenario, like in Kubernetes, music-assistant cannot be reached through websocket, we got a 502 after setting the base_url parameter.

There is a dynamic configuration to handle base_url but in WebsocketClientHandler::handle_client we send the configured one and not the detected one

[Copilot]

Pull request overview

This PR introduces a configurable authentication callback URL so OAuth-style provider flows (e.g., Home Assistant) can redirect to a different externally reachable URL than the internally used base_url (useful behind reverse proxies / Kubernetes ingress).

Changes:

• Add callback_url support to the base Webserver helper and expose it via a new property.
• Add a new callback_url config entry to the Webserver core controller and pass it into webserver startup.
• Switch provider/auth redirect construction to use callback_url instead of base_url.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
music_assistant/helpers/webserver.py	Extends Webserver.setup and properties to include a callback URL.
music_assistant/helpers/auth.py	Uses the configured callback URL when generating auth session callback URLs.
music_assistant/controllers/webserver/controller.py	Adds callback_url to webserver config and startup wiring/logging.
music_assistant/controllers/webserver/auth.py	Uses callback URL for OAuth redirect URI generation.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

[marcelveldt]

Why did you not simply set the URL in the webserver configuration?

[nerzhul]

@marcelveldt unfortunately it broke the websocket communication, for a reason i don't exaclty understand. I suspect that it don't listen anymore after that on the websocket, i got a 502 and it never recover until i remove the base_url from settings.json.
After editing the setting, the app goes to connection lost mode and try to reconnect forever. Maybe my fix is not the right way, it's one of the possible solutions

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

[marcelveldt]

This change does not make sense as this is exactly why we have the setting for the base URL. So instead of introducing a duplicate config value, a user should just make sure that the base URL is correctly configured

[marcelveldt]

@marcelveldt unfortunately it broke the websocket communication, for a reason i don't exaclty understand. I suspect that it don't listen anymore after that on the websocket, i got a 502 and it never recover until i remove the base_url from settings.json. After editing the setting, the app goes to connection lost mode and try to reconnect forever. Maybe my fix is not the right way, it's one of the possible solutions

Then we should instead fix that issue instead of adding a workaround.

[nerzhul]

@marcelveldt unfortunately it broke the websocket communication, for a reason i don't exaclty understand. I suspect that it don't listen anymore after that on the websocket, i got a 502 and it never recover until i remove the base_url from settings.json. After editing the setting, the app goes to connection lost mode and try to reconnect forever. Maybe my fix is not the right way, it's one of the possible solutions

Then we should instead fix that issue instead of adding a workaround.

You're right, i was going the wrong way, let's try to find why in reverse proxy context with a DNS record the WS fail to connect to the backend.

[nerzhul]

ok i think i have the right fix, but i'm not able to build the image due do winedevine CDM, i hope the code is sufficient there

[MarvinSchenkel]

ok i think i have the right fix, but i'm not able to build the image due do winedevine CDM, i hope the code is sufficient there

If you are not using Apple Music during your test, you could simply temporarily comment out the widevine CDM part to build a docker image for testing on your k8s setup?

[nerzhul]

ok i think i have the right fix, but i'm not able to build the image due do winedevine CDM, i hope the code is sufficient there

If you are not using Apple Music during your test, you could simply temporarily comment out the widevine CDM part to build a docker image for testing on your k8s setup?

thanks, let's try, cross compiling for ARM64 :)

[nerzhul]

@MarvinSchenkel just tested it, it works very smoothly :)

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[MarvinSchenkel]

Please undo your test changes to the docker files

[MarvinSchenkel]

Marking this PR as draft so we can keep track of which PRs needs our attention. Please mark as 'Ready for review' when you want us to have another look 🙏 .

[nerzhul]

@marcelveldt rebased & removed my junk, my bad

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[MarvinSchenkel]

Copilot has a good point here

[nerzhul]

i just identified this PR is not required anymore. I found the cullprint. This may required for some other things, but in my case it's not required anymore.