Skip to content

fix wrong base_url in reverse_proxy scenario to connect WSS #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nerzhul wants to merge 1 commit into from
+4 −0
Closed

fix wrong base_url in reverse_proxy scenario to connect WSS #3855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions music_assistant/controllers/webserver/websocket_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,11 @@ async def handle_client(self) -> web.WebSocketResponse:
self._writer_task = self.mass.create_task(self._writer())

# send server(version) info when client connects
# Use proxy-aware base_url if available (set from X-Forwarded-Host in __init__),
# otherwise fall back to the configured base_url
server_info = self.mass.get_server_info()
if self.base_url:
server_info.base_url = self.base_url
Comment on lines 103 to +105
Copy link
Copy Markdown
Contributor

@MarvinSchenkel MarvinSchenkel May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot has a good point here

await self._send_message(server_info)
Comment on lines +102 to 106

# Block until onboarding is complete
Expand Down
Loading