target_type is no more#33
Merged
Merged
Conversation
target_type was an enum that was built from the combination of section_type and compartments (this was a bool). Now we have 2 enums that are passed by string in report.conf. This has several benefits: - inspection: we can understand more easily what we are passing - de-correlation: we can change one enum without changing the other - no need of special encoding/decoding: before we needed to pack and unpack the enums into 1 - easier to expand in case more options arise Drawbacks: - less performant since we need to encode/decode with strings I think the drawback are totally ininfluent. Report parsing is not performance critical and clarity and simplicity should rein here
nrnhines
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
target_type was an enum that was built from the combination of section_type and compartments (this was a bool).
Now we have 2 enums that are passed by string in report.conf. This has several benefits:
Drawbacks:
I think the drawback are totally ininfluent. Report parsing is not performance critical and clarity and simplicity should rein here